On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via Linuxptp-devel 
wrote:
> After first timeout of Announce message ptp4l will send Announce
> requests messages to all of configured non-master clock peers
> without updating timeout on approval packet making huge unneeded
> workload on servers. Fix it by updating announce timeout correctly.

I don't understand what the issue is or how this patch solves it.

 
> @@ -467,6 +467,7 @@ void unicast_client_grant(struct port *p, struct 
> ptp_message *m,
>       ucma->granted |= 1 << mtype;
>  
>       switch (ucma->state) {
> +     case UC_HAVE_ANN:

Client should not receive a grant for ANNOUNCE in state HAVE_ANNOUNCE.
How does this happen?

Thanks,
Richard


>       case UC_WAIT:
>               if (mtype == ANNOUNCE) {
>                       ucma->state = unicast_fsm(ucma->state, UC_EV_GRANT_ANN);
> @@ -474,8 +475,6 @@ void unicast_client_grant(struct port *p, struct 
> ptp_message *m,
>                       unicast_client_set_renewal(p, ucma, g->durationField);
>               }
>               break;
> -     case UC_HAVE_ANN:
> -             break;
>       case UC_NEED_SYDY:
>               switch (mtype) {
>               case DELAY_RESP:
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to