On Wed, 29 Mar 2023 at 14:37, Luigi 'Comio' Mantellini < luigi.mantell...@gmail.com> wrote:
> Hi Erez, > > sorry, I usually use pull requests. > Me too :-) But using patch seria is cool too. > > > Il giorno mer 29 mar 2023 alle ore 14:29 Erez <erezge...@gmail.com> ha > scritto: > >> >> >> On Wed, 29 Mar 2023 at 11:28, Luigi Mantellini < >> luigi.mantell...@gmail.com> wrote: >> >>> The actual ptp4l implementation rearms timers on timeut. This doesn't >>> permit to have a precise TX SYNC >> >> >> Did you misspell "timeout"? >> > > yes > > >> >> >>> message scheduling. >>> The following patchset uses non blocking timers and only for TX SYNC >>> timer a periodic timer is used. >>> In addition, a periodic timer requires to read (and flush) the file >>> descriptor and a new timerfd_flush() function has been introduced for this. >>> >>> >> Cool :-) >> This explanation is coherent. >> >> We usually add a cover letter, using 'git format-patch' with the >> '--cover-letter' options. >> And please add a short explanation on the issue you solve to each patch >> (relevant to each patch). >> And if the solution is not trivial, a short explanation on the solution >> as well. >> >> I will provide it soon. Can you give a look at the code also? I tested > with a custom ethernet device and I cannot test with common hw (like intel > nic). > We have some Intel engineers, they will probably do. And also Miroslav Lichvar from Red hat that also provides a simulator, you can use for testing. Erez > Thanks, > > luigi > > Thanks >> Erez >> >> >>> e2e_tc.c | 28 +++++++++++++++++++++------- >>> fd.h | 4 ++-- >>> p2p_tc.c | 28 +++++++++++++++++++++------- >>> port.c | 102 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------ >>> port.h | 10 ++++++++++ >>> raw.c | 4 ++-- >>> udp.c | 4 ++-- >>> udp6.c | 4 ++-- >>> 8 files changed, 132 insertions(+), 52 deletions(-) >>> >>> [PATCH 1/6] Use constant FD_EVENT and FD_GENERAL instead numeric >>> [PATCH 2/6] Rearrange the fdarray in order to serve timers before >>> [PATCH 3/6] Flush timer fd after expiration >>> [PATCH 4/6] Split announce/sync_rx timer rearm on expiration fd >>> [PATCH 5/6] Use Non-blocking timer file descriptors >>> [PATCH 6/6] Use periodic timer for TX SYNC timeout >>> >>> >>> >>> _______________________________________________ >>> Linuxptp-devel mailing list >>> Linuxptp-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel >>> >> > > -- > *Luigi 'Comio' Mantellini* > My Professional Profile <http://www.linkedin.com/in/comio> > > *"UNIX is very simple, it just needs a genius to understand its > simplicity." [cit.]* > >
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
