On Tue, Jul 04, 2023 at 12:30:37PM +0200, Stephan Wurm wrote:
> This patch series adds support for doubly-attached clocks as described
> in IEC 62439-3:2016 Appendix A.

Without having a copy of that, I'm going to have a hard time
swallowing this patch set.

Overall, I can't see the reason for this series.  I don't think it
actually solves a problem.

For HSR, the Red Box can/should remove the duplicates, and you can
simply run a PTP OC on the single inner port.

For PRP ...

> Both interfaces of a redundant connection need to be handled
> individually, although they are connected to the same grandmaster.
> The synchronized port in SLAVE state is then backed-up by the redundant
> port, which remains in PASSIVE state, unless the former port enters
> FAULTY state. The PASSIVE redundant port can then step in immediately.

In a PRP network, you have two separate networks.  The nodes with two
ports can simply run a normal BC.  The node with one port can run OC.
Just leave off the PRP trailer.

So if you want to make a convincing argument for your patch series,
you need to explain three things.

1. context
2. problem
3. solution

For example, something like:

Context
   The Parallel Redundancy Protocol (PRP) is a network protocol that ... 

Problem
   One might try to deploy a PTP BC in a PRP network, but that leads
   to issues...

Solution
  This series addresses the issues by re-writing everything ... ;^)

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to