On Thu, 09 Nov, 2023 21:17:03 -0800 Richard Cochran <richardcoch...@gmail.com> wrote: > On Mon, Sep 25, 2023 at 10:03:09AM -0700, Rahul Rameshbabu via Linuxptp-devel > wrote: >> The name NSEC2SEC implies converting nanoseconds to seconds, but the value >> used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the >> accurate name for this macro. Move macro to common location in util.h. > > This patch really has nothing to do with the topic as stated in the > cover letter. I agree that the existing macro is poorly named, but > the change really needs its own patch series. > > If you feel like making the change, then please make a patch series, > starting with adding the new macro, and then converting the modules > one by one to the new macro. That way a) the review is easier, and > b) reverts are easier in case of regression in one module.
Ack. I do want to make this change and agree with this feedback. I'll send out a patch series for this next week. -- Thanks, Rahul Rameshbabu _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
