> Yes, that makes sense. Would you also share your real name so I can
credit you
> for your patch?
I'm fine with being uncredited or using justnope.
Another thing I noticed but I'm unable to test is that in
Serialization.cpp the return value of abi::__cxa_demangle isn't freed.
On 03/02/2019 16:30, Christian Schoenebeck wrote:
Or if c++11 is acceptable I could just use auto.
Adding a C++11 dependency just for this minor issue is really not neccessary.
I just googled "ssize_t windows" and the solution seems to be:
I've used the typedef and a check for msvc 2015 or higher. If it's a
lower version an preprocessor error gets displayed. Installing 2013 only
to check if it works seems overkill.
I see that you actually disabled demangling completely for msvc. I am not
sure, but isn't there an alternative function for mscv that's called
undecorate symbols "unDec" or something? At least that's what I found
somebody suggested on the net.
I've disabled it temporarily. I did some searching and I think I can use
dbghelp.dll it's supposed to be included in every version of windows.
Another option was to use boost, I thought it included a demangler. The
advantage is that it is cross platform, but maybe it's a bit too heavy
handed. I don't know what your thoughts are on using boost.
As you already assumed, I would like to avoid new dependencies as much as
possible.
I've implemented demangling and it seems to work.
I've used dbghelp.dll. It's also possible to use an undocumented crt
function, but I rather add a dependency on dbghelp (which is always
installed on windows) than using that undocumented crt function.
When you use raw_name it gives you a string that you can demangle but it
adds a "." in the beginning of the string which you must skip.
The question I have is that in the documentation it states that function
I call to demangle is not thread safe. So the question I have is: can
DataType::customTypeName be called from different threads?
I'm also able to build all the tools except for: akaiextract, gig2mono,
gig2stereo. The reason is I have to write a replacement for opendir.
Maybe at a later date it can be implemented if there's demand for it.
The other tools compiled without any modification.
_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
