On Montag, 11. Februar 2019 14:49:22 CET justnope wrote: > Could you check the attached patch for possible mistakes or things you'd > like to see implemented differently?
Looks fine to me. Just one last thing: You added CMake files and I wonder what's better, placing those CMake files directly at the individual locations like you did, or rather putting them into a dedicated subdir like "msvc" altogether. The thing is, obviously right now we do not support cmake on Linux etc., so it is not a real issue yet. But one day somebody will ask for compiling libgig with cmake on other platforms as well. Obviously the best way would be sharing the CMake files among all platforms and just wrapping the architecture/compiler specific portions with conditions. Would that be easily possible? Last time I looked into this with cmake I think there were some substantial limitations, but I can't remember anymore what exactly. CU Christian _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
