On Samstag, 9. Februar 2019 21:59:59 CET Ivan Maguidhir wrote: > Hi all,
Hi Ivan, > I'm just writing to submit this patch that I've been working on / > testing for the last while. So far I haven't had the time to look at your patch thoroughly yet, but here some questions ... > The patch provides code for reading and updating 'XFIL' and 'DOXF' > chunks during load and save operations. The 'XFIL' chunk gives the > count, filenames and expected dlsids of extension files except a .gx99 > file if present. The presence of a 'DOXF' chunk indicates that a .gx99 > extension file should be present on disk and the chunk itself provides > the expected dlsid. Are those chunk types also used by GSt or have you introduced them? If you have introduced them, what are the precise reasons for introducing them? > I have tested multi-part .gig files as well as ordinary 32-bit offset > .gig files saved with this patch applied in GSEdit3 and GStdio3 and they > load and play as expected. I haven't tested the changes with a library > consisting of a single .gig file which uses 64-bit offsets as I don't > have any of those to hand. There shouldn't be any change for files that > don't have extension files though. GSt never supported gig files with 64 bit RIFF file offsets. I introduced that feature to allow writing gig files larger than 4 GB witht libgig, as one large gig file without extension files that is: http://doc.linuxsampler.org/Release_Notes/LinuxSampler_2_1_0/#libgig_4_1_0 Having said that, I currently wonder how to expose those two saving options to the API appropriately. My first thought was that mixing both 64 bit offsets with extension files does not make sense and that it should be thus an either or. That is if a gig file already uses extension files then it would obviously save changes distributed over extension files by using all 32 bit offsets, otherwise if somebody creates a new gig file from scratch with libgig then only when explicitly picking offset_size_32bit would cause extension files to be written. But on second thought, using both 64 bit and extensions files at the same time might be beneficial to split out certain aspects of a gig file intentionally to separate files while at the same time retaining things in large files. For instance what I could imagine is storing all samples of one sample group to the same file and distributing the individual sample groups over individual files.. That way sound designers could gain an option to create libraries in a more modular approach if desired, which is already standard with almost any other mordern sound library file format. CU Christian _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
