On 20/02/2019 12:36, Christian Schoenebeck wrote:
Please share your design ideas before implementing anything to avoid substantial code rewrites later on.
Sorry about that. I will in future.
For example looking at your screen shot, I don't think that setting a maximum file size for extension files is necessary at all. I think the GSt way of saving extension files (.gx01, .gx02, ... , .gx99) should only be used for saving gig files intended to be compatible with the GigaStudio software, and in that case the max. files size would be always 2GB anyway.
The changes I've made to gigedit and libgig are only for creating Gigastudio compatible extension files. I included the max file size setting only because it's there in the GSt3 save dialog. As you correctly point out no one would really need to change this value. The default setting in the GSt3 editor is 2040. I think this is in mebibytes. My idea was to add/remove extension files as samples are being added/removed instead of doing all the work of splitting the .gig up during a File::Save().
For the more flexible approach (not intended to be compatible with GigaStudio) that we recently discussed, I do have other plans: for instance it would not use the .gxYY scheme at all, most notably because I want those extension files to have a) any name, not just the same base name as main gig file, and b) I want those extension files to be loadable from different directories than the main gig file in order to allow sharing individual extension files among multiple main gig files.
That sounds great.
Please also note that I am currently adjusting your previous libgig patch for allowing to save also with a different amount of extension files. So keep that in mind to avoid we two are working on the same thing. I expect to commit these libgig changes in the next couple hours.
Many thanks for doing that.
CU Christian
All the best, Ivan _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
