On Montag, 25. Februar 2019 21:05:22 CET Jacek Roszkowski wrote: > pon., 25 lut 2019 o 19:10 Christian Schoenebeck > > <schoeneb...@linuxsampler.org> napisał(a): > > From what you described so far, I don't see why you would need to open a > > separate concept to the existing key group conflict concept. As far as I > > can see it, the key group concept just would need some additional options > > for allowing what you want to do. > > Thank you for your explanations. I'm a hobbyist drummer and hobbyist > programmer and I don't aspire to bring a final solution for those > issues.
I did not suggest you to come up with a final solution. I just said that modifying the existing key group code makes more sense than adding a completely separate code inside the sfz classes which would handle the same thing as the existing key group code. It requires actually far less code to just modify the key group code than adding your previously suggested patch. Where do you see difficulties extending the key group code for your purpose? > I suppose the common engine interface is not going to be > released in near future. What do you mean with common interface released? We already do have a shared code base for all 3 engines. Almost all engine code is shared code, and all new engine features are always added to that shared code base for several years now. That's a continuous, non-formal process. If somebody needs to change some interface of the shared engine code for some new feature, then he simply does that. That's a not a public API, so we can quickly change things there without having to vote or something. We have put a lot of work in actually deduplicating all the code we had for the individual engines before; it does not make sense to turn back time and piling up yet again code inside the individual (non shared) engine code for things that would be needed in the other engines later on. CU Christian _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
