Hi Christian
On 14/12/2019 17:26, Christian Schoenebeck wrote:
Ok, I just committed 2 parts of your patch. I committed your 128 '3gnm' chunks
patch unmodified:
http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=3656
Thanks!
Regarding the '3dnm' and '3ddp' chunks: I moved that to UpdateChunks() since I
found that the more appropriate place to be, and I assumed that these chunks
are just required for GigaStudio >= v3, hence these are only added there and
auto removed if user switches back to a previous gig format version:
http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=3657
That sounds good. Actually, I found the '3ddp' tag in several v1.0
instruments that I have. I'll have another look at GSEdit3 later today
to see if I can find out exactly what both of these tags do.
Then your changes to AddDimension(): I could not reproduce that issue and
accordingly I haven't committed that part of your patch yet. In my tests, when
I start with an Instrument with no dimension and then add another dimension I
never ended up with duplicate RIFF chunks. Plus, as far as I can see it, your
suggested changes would introduce other bugs, because e.g. you would be
assigning the same DimensionRegion object several times to different
'pDimensionRegions' array entries. So are you sure you still have issues with
latest libgig SVN version that we would need to address here?
That's weird. I'm not seeing any duplication of the DimensionRegion
chunks with the latest libgig from SVN.
So, you can disregard the last part of the patch. Sorry about that.
CU
Christian
All the best,
Ivan
_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
