On Samstag, 14. Dezember 2019 20:05:35 CET Ivan Maguidhir wrote: > > Regarding the '3dnm' and '3ddp' chunks: I moved that to UpdateChunks() > > since I found that the more appropriate place to be, and I assumed that > > these chunks are just required for GigaStudio >= v3, hence these are only > > added there and auto removed if user switches back to a previous gig > > format version: > > http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=365 > > 7 > That sounds good. Actually, I found the '3ddp' tag in several v1.0 > instruments that I have. I'll have another look at GSEdit3 later today > to see if I can find out exactly what both of these tags do.
In gig v1 even. I can't remember having seen those chunks before with GSt < 3 files. But if it really turns out that these chunks were always there, then we can still change that of course and add them for all gig file format versions. In my TODO list back from that time (2003) I only had a '3dnl' chunk not being supported by libgig on Region level yet: http://svn.linuxsampler.org/cgi-bin/viewvc.cgi/libgig/trunk/TODO?view=markup > > Then your changes to AddDimension(): I could not reproduce that issue and > > accordingly I haven't committed that part of your patch yet. In my tests, > > when I start with an Instrument with no dimension and then add another > > dimension I never ended up with duplicate RIFF chunks. Plus, as far as I > > can see it, your suggested changes would introduce other bugs, because > > e.g. you would be assigning the same DimensionRegion object several times > > to different 'pDimensionRegions' array entries. So are you sure you still > > have issues with latest libgig SVN version that we would need to address > > here? > > That's weird. I'm not seeing any duplication of the DimensionRegion > chunks with the latest libgig from SVN. > So, you can disregard the last part of the patch. Sorry about that. Maybe you were dropping a stereo sample in and misinterpreted the automatically created stereo dimension (a.k.a. "audio channel" dimension) as duplicate chunks. At least so far I couldn't reproduce a problem regarding duplicate chunks there, so I leave it as is for now, but I'll keep an eye on it. CU Christian _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
