On Tue Aug 18 10:09:33 2026 +0800, Linmao Li wrote:
> rppx1_ext_params_blocks_info[] is indexed by block type and is built
> with designated initialisers, so a block type without an entry is left
> as a zero-sized hole. RPPX1_PARAMS_BLOCK_TYPE_AWBG_POST is the only
> such hole: a block reporting that type and a size of zero passes
> v4l2_isp_params_validate_buffer(), which then has nothing to advance
> the walk with.
>
> Describe the block, so the array covers all block types the uAPI
> defines. The MAIN_POST white balance gains module is probed and started
> with the rest of the POST pipe, and RPPX1_PARAMS_MAX_SIZE already
> reserves room for all three white balance gains blocks.
>
> The block is not dispatched by rppx1_params(), in line with the other
> described blocks that have no users yet.
>
> Reviewed-by: Niklas Söderlund <[email protected]>
> Reviewed-by: Jacopo Mondi <[email protected]>
> Signed-off-by: Linmao Li <[email protected]>
> Signed-off-by: Jacopo Mondi <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/dreamchip/rppx1/rpp_params.c | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/drivers/media/platform/dreamchip/rppx1/rpp_params.c
b/drivers/media/platform/dreamchip/rppx1/rpp_params.c
index a75a27a8afd0..5e6727d58946 100644
--- a/drivers/media/platform/dreamchip/rppx1/rpp_params.c
+++ b/drivers/media/platform/dreamchip/rppx1/rpp_params.c
@@ -25,6 +25,7 @@ rppx1_ext_params_blocks_info[] = {
RPPX1_PARAMS_BLOCK_INFO(LSC_PRE2, lsc),
RPPX1_PARAMS_BLOCK_INFO(AWBG_PRE1, awbg),
RPPX1_PARAMS_BLOCK_INFO(AWBG_PRE2, awbg),
+ RPPX1_PARAMS_BLOCK_INFO(AWBG_POST, awbg),
RPPX1_PARAMS_BLOCK_INFO(CCOR_POST, ccor),
RPPX1_PARAMS_BLOCK_INFO(HIST_PRE1, hist),
RPPX1_PARAMS_BLOCK_INFO(HIST_PRE2, hist),
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
