On Tue Jul 28 14:14:16 2026 +0800, Guoniu Zhou wrote:
> The CSI pixel formatter is a module found on i.MX95 used to reformat
> packet info, pixel and non-pixel data from CSI-2 host controller to
> match Pixel Link(PL) definition.
> 
> Add data formatting support.
> 
> Signed-off-by: Guoniu Zhou <[email protected]>
> Reviewed-by: Frank Li <[email protected]>
> Reviewed-by: Loic Poulain <[email protected]>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Frank Li <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 MAINTAINERS                                      |   8 +
 drivers/media/platform/nxp/Kconfig               |  16 +
 drivers/media/platform/nxp/Makefile              |   1 +
 drivers/media/platform/nxp/imx95-csi-formatter.c | 758 +++++++++++++++++++++++
 4 files changed, 783 insertions(+)

---

diff --git a/MAINTAINERS b/MAINTAINERS
index a33b46da5fd3..baf4ca2c3928 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19739,6 +19739,14 @@ S:     Maintained
 F:     Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
 F:     drivers/media/platform/nxp/imx-jpeg
 
+NXP i.MX 95 CSI PIXEL FORMATTER V4L2 DRIVER
+M:     Guoniu Zhou <[email protected]>
+L:     [email protected]
+L:     [email protected]
+S:     Maintained
+F:     Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml
+F:     drivers/media/platform/nxp/imx95-csi-formatter.c
+
 NXP i.MX CLOCK DRIVERS
 M:     Abel Vesa <[email protected]>
 R:     Peng Fan <[email protected]>
diff --git a/drivers/media/platform/nxp/Kconfig 
b/drivers/media/platform/nxp/Kconfig
index 40e3436669e2..5ff263fe7c6f 100644
--- a/drivers/media/platform/nxp/Kconfig
+++ b/drivers/media/platform/nxp/Kconfig
@@ -28,6 +28,22 @@ config VIDEO_IMX8MQ_MIPI_CSI2
          Video4Linux2 driver for the MIPI CSI-2 receiver found on the i.MX8MQ
          SoC.
 
+config VIDEO_IMX95_CSI_FORMATTER
+       tristate "NXP i.MX95 CSI Pixel Formatter driver"
+       depends on ARCH_MXC || COMPILE_TEST
+       depends on PM_CLK
+       depends on VIDEO_DEV
+       select MEDIA_CONTROLLER
+       select MFD_SYSCON
+       select V4L2_FWNODE
+       select VIDEO_V4L2_SUBDEV_API
+       help
+         This driver provides support for the CSI Pixel Formatter found on
+         i.MX95 series SoCs. This module unpacks the pixels received from the
+         CSI-2 interface and reformats them to meet pixel link requirements.
+
+         Say Y here to enable CSI Pixel Formatter module for i.MX95 SoC.
+
 config VIDEO_IMX_MIPI_CSIS
        tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
        depends on ARCH_MXC || COMPILE_TEST
diff --git a/drivers/media/platform/nxp/Makefile 
b/drivers/media/platform/nxp/Makefile
index 4d90eb713652..6410115d870e 100644
--- a/drivers/media/platform/nxp/Makefile
+++ b/drivers/media/platform/nxp/Makefile
@@ -6,6 +6,7 @@ obj-y += imx8-isi/
 
 obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o
 obj-$(CONFIG_VIDEO_IMX8MQ_MIPI_CSI2) += imx8mq-mipi-csi2.o
+obj-$(CONFIG_VIDEO_IMX95_CSI_FORMATTER) += imx95-csi-formatter.o
 obj-$(CONFIG_VIDEO_IMX_MIPI_CSIS) += imx-mipi-csis.o
 obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o
 obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o
diff --git a/drivers/media/platform/nxp/imx95-csi-formatter.c 
b/drivers/media/platform/nxp/imx95-csi-formatter.c
new file mode 100644
index 000000000000..2043f5caaad1
--- /dev/null
+++ b/drivers/media/platform/nxp/imx95-csi-formatter.c
@@ -0,0 +1,758 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2025 NXP
+ */
+
+#include <linux/bits.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pm_clock.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+
+#include <media/mipi-csi2.h>
+#include <media/v4l2-fwnode.h>
+#include <media/v4l2-mc.h>
+#include <media/v4l2-subdev.h>
+
+/* CSI Pixel Formatter registers map */
+
+#define CSI_VC_INTERLACED_LINE_CNT(vc)         (0x00 + (vc) * 0x04)
+#define INTERLACED_ODD_LINE_CNT_SET(x)         FIELD_PREP(GENMASK(13, 0), (x))
+#define INTERLACED_EVEN_LINE_CNT_SET(x)                FIELD_PREP(GENMASK(29, 
16), (x))
+
+#define CSI_VC_INTERLACED_CTRL                 0x20
+
+#define CSI_VC_INTERLACED_ERR                  0x24
+#define CSI_VC_ERR_MASK                                GENMASK(7, 0)
+#define CSI_VC_ERR(vc)                         BIT((vc))
+
+#define CSI_VC_YUV420_FIRST_LINE_EVEN          0x28
+#define YUV420_FIRST_LINE_EVEN(vc)             BIT((vc))
+
+#define CSI_RAW32_CTRL                         0x30
+#define CSI_VC_RAW32_MODE(vc)                  BIT((vc))
+#define CSI_VC_RAW32_SWAP_MODE(vc)             BIT((vc) + 8)
+
+#define CSI_STREAM_FENCING_CTRL                        0x34
+#define CSI_VC_STREAM_FENCING(vc)              BIT((vc))
+#define CSI_VC_STREAM_FENCING_RST(vc)          BIT((vc) + 8)
+
+#define CSI_STREAM_FENCING_STS                 0x38
+#define CSI_STREAM_FENCING_STS_MASK            GENMASK(7, 0)
+
+#define CSI_VC_NON_PIXEL_DATA_TYPE(vc)         (0x40 + (vc) * 0x04)
+
+#define CSI_VC_PIXEL_DATA_CTRL(vc)             (0x60 + (vc) * 0x04)
+#define NEW_VC(vc)                             FIELD_PREP(GENMASK(3, 1), vc)
+#define REROUTE_VC_ENABLE                      BIT(0)
+
+#define CSI_VC_ROUTE_PIXEL_DATA_TYPE(vc)       (0x80 + (vc) * 0x04)
+
+#define CSI_VC_NON_PIXEL_DATA_CTRL(vc)         (0xa0 + (vc) * 0x04)
+
+#define CSI_VC_PIXEL_DATA_TYPE(vc)             (0xc0 + (vc) * 0x04)
+
+#define CSI_VC_PIXEL_DATA_TYPE_ERR(vc)         (0xe0 + (vc) * 0x04)
+
+#define CSI_FORMATTER_PAD_SINK                 0
+#define CSI_FORMATTER_PAD_SOURCE               1
+#define CSI_FORMATTER_PAD_NUM                  2
+
+#define CSI_FORMATTER_VC_NUM                   8 /* Number of virtual channels 
*/
+
+struct csi_formatter_pix_format {
+       u32 code;
+       u32 data_type;
+};
+
+struct csi_formatter {
+       struct device *dev;
+       struct regmap *regs;
+       u32 reg_offset;
+
+       struct v4l2_subdev sd;
+       struct v4l2_async_notifier notifier;
+       struct media_pad pads[CSI_FORMATTER_PAD_NUM];
+
+       struct v4l2_subdev *remote_sd;
+       u32 remote_pad;
+
+       u64 enabled_streams;
+};
+
+struct csi_formatter_dt_index {
+       u8 dtype;
+       u8 index;
+};
+
+/*
+ * The index corresponds to the bit index in the register that enables
+ * the data type of pixel data transported by the Formatter.
+ */
+static const struct csi_formatter_dt_index csi_formatter_dt_to_index_map[] = {
+       { .dtype = MIPI_CSI2_DT_YUV420_8B,        .index = 0 },
+       { .dtype = MIPI_CSI2_DT_YUV420_8B_LEGACY, .index = 2 },
+       { .dtype = MIPI_CSI2_DT_YUV422_8B,        .index = 6 },
+       { .dtype = MIPI_CSI2_DT_RGB444,           .index = 8 },
+       { .dtype = MIPI_CSI2_DT_RGB555,           .index = 9 },
+       { .dtype = MIPI_CSI2_DT_RGB565,           .index = 10 },
+       { .dtype = MIPI_CSI2_DT_RGB666,           .index = 11 },
+       { .dtype = MIPI_CSI2_DT_RGB888,           .index = 12 },
+       { .dtype = MIPI_CSI2_DT_RAW6,             .index = 16 },
+       { .dtype = MIPI_CSI2_DT_RAW7,             .index = 17 },
+       { .dtype = MIPI_CSI2_DT_RAW8,             .index = 18 },
+       { .dtype = MIPI_CSI2_DT_RAW10,            .index = 19 },
+       { .dtype = MIPI_CSI2_DT_RAW12,            .index = 20 },
+       { .dtype = MIPI_CSI2_DT_RAW14,            .index = 21 },
+       { .dtype = MIPI_CSI2_DT_RAW16,            .index = 22 },
+};
+
+static const struct csi_formatter_pix_format csi_formatter_formats[] = {
+       /* YUV formats */
+       { MEDIA_BUS_FMT_UYVY8_1X16,     MIPI_CSI2_DT_YUV422_8B },
+       /* RGB formats */
+       { MEDIA_BUS_FMT_RGB565_1X16,    MIPI_CSI2_DT_RGB565 },
+       { MEDIA_BUS_FMT_RGB888_1X24,    MIPI_CSI2_DT_RGB888 },
+       /* RAW (Bayer and greyscale) formats */
+       { MEDIA_BUS_FMT_SBGGR8_1X8,     MIPI_CSI2_DT_RAW8 },
+       { MEDIA_BUS_FMT_SGBRG8_1X8,     MIPI_CSI2_DT_RAW8 },
+       { MEDIA_BUS_FMT_SGRBG8_1X8,     MIPI_CSI2_DT_RAW8 },
+       { MEDIA_BUS_FMT_SRGGB8_1X8,     MIPI_CSI2_DT_RAW8 },
+       { MEDIA_BUS_FMT_Y8_1X8,         MIPI_CSI2_DT_RAW8 },
+       { MEDIA_BUS_FMT_SBGGR10_1X10,   MIPI_CSI2_DT_RAW10 },
+       { MEDIA_BUS_FMT_SGBRG10_1X10,   MIPI_CSI2_DT_RAW10 },
+       { MEDIA_BUS_FMT_SGRBG10_1X10,   MIPI_CSI2_DT_RAW10 },
+       { MEDIA_BUS_FMT_SRGGB10_1X10,   MIPI_CSI2_DT_RAW10 },
+       { MEDIA_BUS_FMT_Y10_1X10,       MIPI_CSI2_DT_RAW10 },
+       { MEDIA_BUS_FMT_SBGGR12_1X12,   MIPI_CSI2_DT_RAW12 },
+       { MEDIA_BUS_FMT_SGBRG12_1X12,   MIPI_CSI2_DT_RAW12 },
+       { MEDIA_BUS_FMT_SGRBG12_1X12,   MIPI_CSI2_DT_RAW12 },
+       { MEDIA_BUS_FMT_SRGGB12_1X12,   MIPI_CSI2_DT_RAW12 },
+       { MEDIA_BUS_FMT_Y12_1X12,       MIPI_CSI2_DT_RAW12 },
+       { MEDIA_BUS_FMT_SBGGR14_1X14,   MIPI_CSI2_DT_RAW14 },
+       { MEDIA_BUS_FMT_SGBRG14_1X14,   MIPI_CSI2_DT_RAW14 },
+       { MEDIA_BUS_FMT_SGRBG14_1X14,   MIPI_CSI2_DT_RAW14 },
+       { MEDIA_BUS_FMT_SRGGB14_1X14,   MIPI_CSI2_DT_RAW14 },
+       { MEDIA_BUS_FMT_SBGGR16_1X16,   MIPI_CSI2_DT_RAW16 },
+       { MEDIA_BUS_FMT_SGBRG16_1X16,   MIPI_CSI2_DT_RAW16 },
+       { MEDIA_BUS_FMT_SGRBG16_1X16,   MIPI_CSI2_DT_RAW16 },
+       { MEDIA_BUS_FMT_SRGGB16_1X16,   MIPI_CSI2_DT_RAW16 },
+};
+
+static const struct v4l2_mbus_framefmt formatter_default_fmt = {
+       .code = MEDIA_BUS_FMT_UYVY8_1X16,
+       .width = 1920U,
+       .height = 1080U,
+       .field = V4L2_FIELD_NONE,
+       .colorspace = V4L2_COLORSPACE_SMPTE170M,
+       .xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(V4L2_COLORSPACE_SMPTE170M),
+       .ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(V4L2_COLORSPACE_SMPTE170M),
+       .quantization = V4L2_QUANTIZATION_LIM_RANGE,
+};
+
+static const struct csi_formatter_pix_format *csi_formatter_find_format(u32 
code)
+{
+       for (unsigned int i = 0; i < ARRAY_SIZE(csi_formatter_formats); i++) {
+               if (code == csi_formatter_formats[i].code)
+                       return &csi_formatter_formats[i];
+       }
+
+       return NULL;
+}
+
+/* 
-----------------------------------------------------------------------------
+ * V4L2 subdev operations
+ */
+
+static inline struct csi_formatter *sd_to_formatter(struct v4l2_subdev *sdev)
+{
+       return container_of(sdev, struct csi_formatter, sd);
+}
+
+static int __csi_formatter_subdev_set_routing(struct v4l2_subdev *sd,
+                                             struct v4l2_subdev_state *state,
+                                             struct v4l2_subdev_krouting 
*routing)
+{
+       int ret;
+
+       ret = v4l2_subdev_routing_validate(sd, routing,
+                                          V4L2_SUBDEV_ROUTING_ONLY_1_TO_1);
+       if (ret)
+               return ret;
+
+       return v4l2_subdev_set_routing_with_fmt(sd, state, routing,
+                                               &formatter_default_fmt);
+}
+
+static int csi_formatter_subdev_init_state(struct v4l2_subdev *sd,
+                                          struct v4l2_subdev_state *sd_state)
+{
+       struct v4l2_subdev_route routes[] = {
+               {
+                       .sink_pad = CSI_FORMATTER_PAD_SINK,
+                       .sink_stream = 0,
+                       .source_pad = CSI_FORMATTER_PAD_SOURCE,
+                       .source_stream = 0,
+                       .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE,
+               },
+       };
+
+       struct v4l2_subdev_krouting routing = {
+               .num_routes = ARRAY_SIZE(routes),
+               .routes = routes,
+       };
+
+       return __csi_formatter_subdev_set_routing(sd, sd_state, &routing);
+}
+
+static int csi_formatter_subdev_enum_mbus_code(struct v4l2_subdev *sd,
+                                              struct v4l2_subdev_state 
*sd_state,
+                                              struct 
v4l2_subdev_mbus_code_enum *code)
+{
+       if (code->pad == CSI_FORMATTER_PAD_SOURCE) {
+               struct v4l2_mbus_framefmt *fmt;
+
+               if (code->index > 0)
+                       return -EINVAL;
+
+               fmt = v4l2_subdev_state_get_format(sd_state, code->pad,
+                                                  code->stream);
+               code->code = fmt->code;
+               return 0;
+       }
+
+       if (code->index >= ARRAY_SIZE(csi_formatter_formats))
+               return -EINVAL;
+
+       code->code = csi_formatter_formats[code->index].code;
+
+       return 0;
+}
+
+static int csi_formatter_subdev_set_fmt(struct v4l2_subdev *sd,
+                                       struct v4l2_subdev_state *sd_state,
+                                       struct v4l2_subdev_format *format)
+{
+       struct v4l2_mbus_framefmt *fmt;
+
+       if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE &&
+           media_entity_is_streaming(&sd->entity))
+               return -EBUSY;
+
+       if (format->pad == CSI_FORMATTER_PAD_SOURCE)
+               return v4l2_subdev_get_fmt(sd, sd_state, format);
+
+       if (!csi_formatter_find_format(format->format.code))
+               format->format.code = csi_formatter_formats[0].code;
+
+       v4l_bound_align_image(&format->format.width, 1, 0xffff, 2,
+                             &format->format.height, 1, 0xffff, 0, 0);
+
+       /* TODO: Add interlaced format support */
+       format->format.field = V4L2_FIELD_NONE;
+
+       fmt = v4l2_subdev_state_get_format(sd_state, format->pad,
+                                          format->stream);
+       *fmt = format->format;
+
+       /* Propagate the format from sink stream to source stream */
+       fmt = v4l2_subdev_state_get_opposite_stream_format(sd_state, 
format->pad,
+                                                          format->stream);
+       *fmt = format->format;
+
+       return 0;
+}
+
+static int csi_formatter_subdev_set_routing(struct v4l2_subdev *sd,
+                                           struct v4l2_subdev_state *state,
+                                           enum v4l2_subdev_format_whence 
which,
+                                           struct v4l2_subdev_krouting 
*routing)
+{
+       if (which == V4L2_SUBDEV_FORMAT_ACTIVE &&
+           media_entity_is_streaming(&sd->entity))
+               return -EBUSY;
+
+       return __csi_formatter_subdev_set_routing(sd, state, routing);
+}
+
+static u8 csi_formatter_get_index_by_dt(struct csi_formatter *formatter,
+                                       u8 data_type)
+{
+       for (unsigned int i = 0; i < ARRAY_SIZE(csi_formatter_dt_to_index_map); 
++i) {
+               const struct csi_formatter_dt_index *entry =
+                       &csi_formatter_dt_to_index_map[i];
+
+               if (data_type == entry->dtype)
+                       return entry->index;
+       }
+
+       dev_WARN(formatter->dev, "Unsupported data type 0x%x, using default\n",
+                data_type);
+
+       return csi_formatter_dt_to_index_map[0].index;
+}
+
+static int csi_formatter_get_vc(struct csi_formatter *formatter,
+                               struct v4l2_mbus_frame_desc *fd,
+                               unsigned int stream)
+{
+       struct v4l2_mbus_frame_desc_entry *entry = NULL;
+       u8 vc;
+
+       for (unsigned int i = 0; i < fd->num_entries; ++i) {
+               if (fd->entry[i].stream == stream) {
+                       entry = &fd->entry[i];
+                       break;
+               }
+       }
+
+       if (!entry) {
+               dev_err(formatter->dev,
+                       "No frame desc entry for stream %u\n", stream);
+               return -EPIPE;
+       }
+
+       vc = entry->bus.csi2.vc;
+
+       if (vc >= CSI_FORMATTER_VC_NUM) {
+               dev_err(formatter->dev, "Invalid virtual channel %u\n", vc);
+               return -EPIPE;
+       }
+
+       return vc;
+}
+
+static int csi_formatter_get_frame_desc(struct csi_formatter *formatter,
+                                       struct v4l2_mbus_frame_desc *fd)
+{
+       int ret;
+
+       ret = v4l2_subdev_call(formatter->remote_sd, pad, get_frame_desc,
+                              formatter->remote_pad, fd);
+       if (ret < 0 && ret != -ENOIOCTLCMD) {
+               dev_err(formatter->dev, "Failed to get frame desc: %d\n", ret);
+               return ret;
+       }
+
+       /*
+        * If the source doesn't implement .get_frame_desc(), assume a single
+        * stream on VC 0. fd is zero-initialized, only set the fields that have
+        * a non-zero value.
+        */
+       if (ret == -ENOIOCTLCMD) {
+               fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
+               fd->num_entries = 1;
+       }
+
+       return 0;
+}
+
+static void csi_formatter_stop_stream(struct csi_formatter *formatter,
+                                     struct v4l2_subdev_state *state,
+                                     u64 stream_mask)
+{
+       const struct csi_formatter_pix_format *pix_fmt;
+       struct v4l2_mbus_frame_desc fd = {};
+       struct v4l2_subdev_route *route;
+       struct v4l2_mbus_framefmt *fmt;
+       unsigned int reg;
+       unsigned int mask;
+       int vc;
+       int ret;
+
+       ret = csi_formatter_get_frame_desc(formatter, &fd);
+       if (ret)
+               return;
+
+       for_each_active_route(&state->routing, route) {
+               if (!(stream_mask & BIT_ULL(route->source_stream)))
+                       continue;
+
+               vc = csi_formatter_get_vc(formatter, &fd, route->sink_stream);
+               if (vc < 0)
+                       continue;
+
+               fmt = v4l2_subdev_state_get_format(state, route->sink_pad,
+                                                  route->sink_stream);
+
+               pix_fmt = csi_formatter_find_format(fmt->code);
+               if (WARN_ON(!pix_fmt))
+                       continue;
+
+               reg = CSI_VC_PIXEL_DATA_TYPE(vc) + formatter->reg_offset;
+               mask = BIT(csi_formatter_get_index_by_dt(formatter,
+                                                        pix_fmt->data_type));
+
+               /* Clear the data type bit to disable this VC */
+               regmap_clear_bits(formatter->regs, reg, mask);
+       }
+}
+
+static int csi_formatter_start_stream(struct csi_formatter *formatter,
+                                     struct v4l2_subdev_state *state,
+                                     u64 stream_mask)
+{
+       const struct csi_formatter_pix_format *pix_fmt;
+       struct v4l2_subdev_route *route;
+       struct v4l2_mbus_framefmt *fmt;
+       struct v4l2_mbus_frame_desc fd = {};
+       u64 configured_streams = 0;
+       unsigned int reg;
+       unsigned int mask;
+       int vc;
+       int ret;
+
+       ret = csi_formatter_get_frame_desc(formatter, &fd);
+       if (ret)
+               return ret;
+
+       for_each_active_route(&state->routing, route) {
+               if (!(stream_mask & BIT_ULL(route->source_stream)))
+                       continue;
+
+               vc = csi_formatter_get_vc(formatter, &fd, route->sink_stream);
+               if (vc < 0) {
+                       ret = vc;
+                       goto err_cleanup;
+               }
+
+               fmt = v4l2_subdev_state_get_format(state, route->sink_pad,
+                                                  route->sink_stream);
+
+               pix_fmt = csi_formatter_find_format(fmt->code);
+               if (WARN_ON(!pix_fmt)) {
+                       ret = -EINVAL;
+                       goto err_cleanup;
+               }
+
+               reg = CSI_VC_PIXEL_DATA_TYPE(vc) + formatter->reg_offset;
+               mask = BIT(csi_formatter_get_index_by_dt(formatter,
+                                                        pix_fmt->data_type));
+
+               /* Set the data type bit to enable this VC */
+               regmap_set_bits(formatter->regs, reg, mask);
+
+               configured_streams |= BIT_ULL(route->source_stream);
+       }
+
+       return 0;
+
+err_cleanup:
+       csi_formatter_stop_stream(formatter, state, configured_streams);
+       return ret;
+}
+
+static int csi_formatter_subdev_enable_streams(struct v4l2_subdev *sd,
+                                              struct v4l2_subdev_state *state,
+                                              u32 pad, u64 streams_mask)
+{
+       struct csi_formatter *formatter = sd_to_formatter(sd);
+       struct device *dev = formatter->dev;
+       u64 sink_streams;
+       int ret;
+
+       sink_streams = v4l2_subdev_state_xlate_streams(state,
+                                                      CSI_FORMATTER_PAD_SOURCE,
+                                                      CSI_FORMATTER_PAD_SINK,
+                                                      &streams_mask);
+       if (!sink_streams || !streams_mask)
+               return -EINVAL;
+
+       if (!formatter->enabled_streams) {
+               ret = pm_runtime_resume_and_get(formatter->dev);
+               if (ret < 0) {
+                       dev_err(dev, "Failed to resume runtime PM: %d\n", ret);
+                       return ret;
+               }
+       }
+
+       ret = csi_formatter_start_stream(formatter, state, streams_mask);
+       if (ret)
+               goto err_runtime_put;
+
+       ret = v4l2_subdev_enable_streams(formatter->remote_sd,
+                                        formatter->remote_pad,
+                                        sink_streams);
+       if (ret)
+               goto err_stop_stream;
+
+       formatter->enabled_streams |= streams_mask;
+
+       return 0;
+
+err_stop_stream:
+       csi_formatter_stop_stream(formatter, state, streams_mask);
+err_runtime_put:
+       if (!formatter->enabled_streams)
+               pm_runtime_put_autosuspend(formatter->dev);
+       return ret;
+}
+
+static int csi_formatter_subdev_disable_streams(struct v4l2_subdev *sd,
+                                               struct v4l2_subdev_state *state,
+                                               u32 pad, u64 streams_mask)
+{
+       struct csi_formatter *formatter = sd_to_formatter(sd);
+       u64 sink_streams;
+       int ret;
+
+       sink_streams = v4l2_subdev_state_xlate_streams(state,
+                                                      CSI_FORMATTER_PAD_SOURCE,
+                                                      CSI_FORMATTER_PAD_SINK,
+                                                      &streams_mask);
+       if (!sink_streams || !streams_mask)
+               return -EINVAL;
+
+       ret = v4l2_subdev_disable_streams(formatter->remote_sd, 
formatter->remote_pad,
+                                         sink_streams);
+       if (ret)
+               dev_err(formatter->dev, "Failed to disable streams: %d\n", ret);
+
+       csi_formatter_stop_stream(formatter, state, streams_mask);
+
+       formatter->enabled_streams &= ~streams_mask;
+
+       if (!formatter->enabled_streams)
+               pm_runtime_put_autosuspend(formatter->dev);
+
+       return ret;
+}
+
+static const struct v4l2_subdev_pad_ops formatter_subdev_pad_ops = {
+       .enum_mbus_code         = csi_formatter_subdev_enum_mbus_code,
+       .get_fmt                = v4l2_subdev_get_fmt,
+       .set_fmt                = csi_formatter_subdev_set_fmt,
+       .get_frame_desc         = v4l2_subdev_get_frame_desc_passthrough,
+       .set_routing            = csi_formatter_subdev_set_routing,
+       .enable_streams         = csi_formatter_subdev_enable_streams,
+       .disable_streams        = csi_formatter_subdev_disable_streams,
+};
+
+static const struct v4l2_subdev_ops formatter_subdev_ops = {
+       .pad = &formatter_subdev_pad_ops,
+};
+
+static const struct v4l2_subdev_internal_ops formatter_internal_ops = {
+       .init_state = csi_formatter_subdev_init_state,
+};
+
+/* 
-----------------------------------------------------------------------------
+ * Media entity operations
+ */
+
+static const struct media_entity_operations formatter_entity_ops = {
+       .link_validate  = v4l2_subdev_link_validate,
+       .get_fwnode_pad = v4l2_subdev_get_fwnode_pad_1_to_1,
+};
+
+static int csi_formatter_subdev_init(struct csi_formatter *formatter)
+{
+       struct v4l2_subdev *sd = &formatter->sd;
+       int ret;
+
+       v4l2_subdev_init(sd, &formatter_subdev_ops);
+
+       strscpy(sd->name, dev_name(formatter->dev), sizeof(sd->name));
+       sd->internal_ops = &formatter_internal_ops;
+
+       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                    V4L2_SUBDEV_FL_STREAMS;
+       sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
+       sd->entity.ops = &formatter_entity_ops;
+       sd->dev = formatter->dev;
+
+       formatter->pads[CSI_FORMATTER_PAD_SINK].flags = MEDIA_PAD_FL_SINK
+                                                     | 
MEDIA_PAD_FL_MUST_CONNECT;
+       formatter->pads[CSI_FORMATTER_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE;
+
+       ret = media_entity_pads_init(&sd->entity, CSI_FORMATTER_PAD_NUM,
+                                    formatter->pads);
+       if (ret) {
+               dev_err(formatter->dev, "Failed to init pads\n");
+               return ret;
+       }
+
+       ret = v4l2_subdev_init_finalize(sd);
+       if (ret)
+               media_entity_cleanup(&sd->entity);
+
+       return ret;
+}
+
+static inline struct csi_formatter *
+notifier_to_csi_formatter(struct v4l2_async_notifier *n)
+{
+       return container_of(n, struct csi_formatter, notifier);
+}
+
+static int csi_formatter_notify_bound(struct v4l2_async_notifier *notifier,
+                                     struct v4l2_subdev *sd,
+                                     struct v4l2_async_connection *asc)
+{
+       const unsigned int link_flags = MEDIA_LNK_FL_IMMUTABLE
+                                     | MEDIA_LNK_FL_ENABLED;
+       struct csi_formatter *formatter = notifier_to_csi_formatter(notifier);
+       struct v4l2_subdev *sdev = &formatter->sd;
+       struct media_pad *sink = &sdev->entity.pads[CSI_FORMATTER_PAD_SINK];
+       int ret;
+
+       formatter->remote_sd = sd;
+
+       ret = v4l2_create_fwnode_links_to_pad(sd, sink, link_flags);
+       if (ret < 0)
+               return ret;
+
+       formatter->remote_pad = media_pad_remote_pad_first(sink)->index;
+
+       return 0;
+}
+
+static const struct v4l2_async_notifier_operations formatter_notify_ops = {
+       .bound = csi_formatter_notify_bound,
+};
+
+static int csi_formatter_async_register(struct csi_formatter *formatter)
+{
+       struct device *dev = formatter->dev;
+       struct v4l2_async_connection *asc;
+       int ret;
+
+       struct fwnode_handle *ep __free(fwnode_handle) =
+               fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 0, 0,
+                                               FWNODE_GRAPH_ENDPOINT_NEXT);
+       if (!ep)
+               return -ENOTCONN;
+
+       v4l2_async_subdev_nf_init(&formatter->notifier, &formatter->sd);
+
+       asc = v4l2_async_nf_add_fwnode_remote(&formatter->notifier, ep,
+                                             struct v4l2_async_connection);
+       if (IS_ERR(asc)) {
+               ret = PTR_ERR(asc);
+               goto err_cleanup_notifier;
+       }
+
+       formatter->notifier.ops = &formatter_notify_ops;
+
+       ret = v4l2_async_nf_register(&formatter->notifier);
+       if (ret)
+               goto err_cleanup_notifier;
+
+       ret = v4l2_async_register_subdev(&formatter->sd);
+       if (ret)
+               goto err_unregister_notifier;
+
+       return 0;
+
+err_unregister_notifier:
+       v4l2_async_nf_unregister(&formatter->notifier);
+err_cleanup_notifier:
+       v4l2_async_nf_cleanup(&formatter->notifier);
+       return ret;
+}
+
+static void csi_formatter_async_unregister(struct csi_formatter *formatter)
+{
+       v4l2_async_unregister_subdev(&formatter->sd);
+       v4l2_async_nf_unregister(&formatter->notifier);
+       v4l2_async_nf_cleanup(&formatter->notifier);
+}
+
+static DEFINE_RUNTIME_DEV_PM_OPS(csi_formatter_pm_ops,
+                                pm_clk_suspend, pm_clk_resume, NULL);
+
+static int csi_formatter_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct csi_formatter *formatter;
+       int ret;
+
+       formatter = devm_kzalloc(dev, sizeof(*formatter), GFP_KERNEL);
+       if (!formatter)
+               return -ENOMEM;
+
+       formatter->dev = dev;
+
+       formatter->regs = syscon_node_to_regmap(dev->parent->of_node);
+       if (IS_ERR(formatter->regs))
+               return dev_err_probe(dev, PTR_ERR(formatter->regs),
+                                    "Failed to get csi formatter regmap\n");
+
+       ret = of_property_read_u32(dev->of_node, "reg", &formatter->reg_offset);
+       if (ret < 0)
+               return dev_err_probe(dev, ret,
+                                    "Failed to get csi formatter reg 
property\n");
+
+       ret = devm_pm_clk_create(dev);
+       if (ret)
+               return ret;
+
+       ret = of_pm_clk_add_clks(dev);
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "Failed to add clocks\n");
+
+       ret = csi_formatter_subdev_init(formatter);
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "Failed to initialize formatter 
subdev\n");
+
+       platform_set_drvdata(pdev, formatter);
+
+       /* Enable runtime PM with autosuspend. */
+       pm_runtime_set_autosuspend_delay(dev, 1000);
+       pm_runtime_use_autosuspend(dev);
+       ret = devm_pm_runtime_enable(dev);
+       if (ret)
+               goto err_pm_disable;
+
+       ret = csi_formatter_async_register(formatter);
+       if (ret < 0) {
+               dev_err_probe(dev, ret, "Failed to register async subdevice\n");
+               goto err_pm_disable;
+       }
+
+       return 0;
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(dev);
+       v4l2_subdev_cleanup(&formatter->sd);
+       media_entity_cleanup(&formatter->sd.entity);
+       return ret;
+}
+
+static void csi_formatter_remove(struct platform_device *pdev)
+{
+       struct csi_formatter *formatter = platform_get_drvdata(pdev);
+
+       csi_formatter_async_unregister(formatter);
+
+       pm_runtime_dont_use_autosuspend(&pdev->dev);
+       pm_runtime_suspend(&pdev->dev);
+
+       v4l2_subdev_cleanup(&formatter->sd);
+       media_entity_cleanup(&formatter->sd.entity);
+}
+
+static const struct of_device_id csi_formatter_of_match[] = {
+       { .compatible = "fsl,imx95-csi-formatter" },
+       { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, csi_formatter_of_match);
+
+static struct platform_driver csi_formatter_device_driver = {
+       .driver = {
+               .name           = "csi-pixel-formatter",
+               .of_match_table = csi_formatter_of_match,
+               .pm             = pm_ptr(&csi_formatter_pm_ops),
+       },
+       .probe  = csi_formatter_probe,
+       .remove = csi_formatter_remove,
+};
+
+module_platform_driver(csi_formatter_device_driver);
+
+MODULE_AUTHOR("NXP Semiconductor, Inc.");
+MODULE_DESCRIPTION("NXP i.MX95 CSI Pixel Formatter driver");
+MODULE_LICENSE("GPL");
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to