Hi Ron, Nice to hear from you again. Thank you for the patches. Please see my comments in-line.
Ping On Sat, Jan 9, 2010 at 7:20 PM, Ron <[email protected]> wrote: > Signed-off-by: Ron Lee <[email protected]> > --- > > Another trivial one, that hopefully should save us some "how does it work" > faqs from end users. The current xsetwacom --list output gives me: > > "Wacom Graphire3" eraser ERASER > "Wacom Graphire3" cursor CURSOR > "Wacom Graphire3" STYLUS > > It wasn't initially obvious to me which part of that was what --get/set > wanted as its 'dev_name' identifier. After looking at the code it is, > but we can probably lower the bar a little further pretty easily. > The following, or some variation on the theme, should help there. > > So long as it's clear '"Wacom Graphire3" eraser' is the verbatim dev_name, > I don't really mind how it is formatted. '"Wacom Graphire3" eraser' works for me. > > Peter: would it be worth accepting and matching on the type name for > --get/set too? Or are those too likely to be ambiguous? We already What happens if we have more than one tablet or more than one tool with the same type? Do we list all of the tool with the same type? > accept the id number, and --get ERASER is a bit less horrible to type > than the quoted monster above anyhow. I can send another patch for > that if you think it's worth having... We don't have to use that "monster" :). But we do need a way to get/set the specific tool's info with an unique parameter. Do you have a suggestion? As for the patch below, the initial reason for the output was to make it backward compatible with the old xsetwacom so we may be able to use some of the existing programs, such as wacomcpl, if there is no other alternatives available for us. I am open to changes, especially when it makes the driver and xsetwacom more user friendly. But, I think we need to have an alternative before we break the existing one. Any suggestion on a new GUI to replace wacomcpl? > diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c > index f7817b2..6673a28 100644 > --- a/tools/xsetwacom.c > +++ b/tools/xsetwacom.c > @@ -980,7 +980,7 @@ static void list_one_device(Display *dpy, XDeviceInfo > *info) > if (nitems) > { > type_name = XGetAtomName(dpy, *(Atom*)data); > - printf("%-16s %-10s\n", info->name, > type_name); > + printf("type: %-10s name: '%s'\n", type_name, > info->name); > } > > XFree(data); > -- > 1.6.5.3 ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
