Hi developers,
I'd like to ask opinion on storing default values internally. This is
indirectly a review comment on Jason Childs patch #0023.
I've a question about the practice of keeping 2 variables, such as
wcmCapacity and wcmCapacityDefault, where one is for user configurable
values and other is static but initialized to hardware specific values.
There seems to be two usages for this practice of having a *Default version
of a variable:
1) Since these *Default variables are basically static and hardware specific
values, it can be used as a way to see when hardware supports a feature
regardless of how user has requested to over ride (see wcmCapacityDefault as
prime example).
2) A way to keep around default values even when user over rides so that
they can always be queried using xf86WcmGetDefaultParam() . I notice
xf86-input-wacom doesn't support this code path so I supect its not that
useful.
Is this code path in #2 used by anyone? Should we mantaining these "static
but runtime init'ed" values if its only purpose is #2?
Some stats: Currently, xdrv has 4 of these type values and Jason patches
related to gestures on Bamboo P&T will increase to total of 10. Out of
those 4/10 values, I think only 2 (wcmTouchDefault and wcmCapacityDefault)
are used for case #1.
Chris
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
