On Wed, Jan 27, 2010 at 08:51:50PM -0800, Ping Cheng wrote: > > > > 1) Since these *Default variables are basically static and hardware > > specific values, it can be used as a way to see when hardware supports a > > feature regardless of how user has requested to over ride (see > > wcmCapacityDefault as prime example). > > > > You are right. > > > > 2) A way to keep around default values even when user over rides so that > > they can always be queried using xf86WcmGetDefaultParam() . I notice > > xf86-input-wacom doesn't support this code path so I supect its not that > > useful. > > > > You right on this one too. xf86-input-wacom doesn't support (at least now) > wcmGetDefaultParam. This means any utility programs which need to set a > value to default would have to compute or derive the default value by the ID > of the tool or tablet. I am not sure if this is a good solution for the > utility programs or not. Peter would be able to answer this question better > than me since he provided the new xsetwacom support. Let's see what he > prefers. > > Is this code path in #2 used by anyone? Should we mantaining these "static > > but runtime init'ed" values if its only purpose is #2? > > > > I think we need to keep the defaults in the driver so we don't have to > derive it each time when we need them during the runtime. But, this is > debatable and I will go with the majority.
from what I can tell, there's two classes of defaults. those obtained by the hardware and "arbitrarily" chosen defaults. the former include things like the axis range, the latter things like suppression thresholds, acceleration settings, etc. IMO, only hardware defaults should be stored in the driver. The others can be built in when the driver starts up but IMO shouldn't have a queryable default. The reason is simple - there's no definition of "default" for some values. What's the default for acceleration? It depends on your other devices - if you have a very fast mouse setting you'd likely want the wacom acceleration to be fast as well. Or not - who knows. The driver doesn't know about anything else though, so a managing program like gnome-wacom-settings, kwacom, or whatever it will be (is?) called can maintain these. Alternatively, even the defaults that need to be stored in the driver could at least be cleaned up to be handled by a couple of defines and/or tables. These can then get loaded based on the product ID (or similar). Cheers, Peter ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
