On Mon, Feb 22, 2010 at 04:13:17PM -0600, Chris Bagwell wrote:
> Looks good to me overall.  I wondered during review of linuxwacom
> patch about needing to remap buttons > 3 to be in range > 7.
> 
> Ideally, I would hope we could 1-up this patch and look at tablet_id
> and in cases that have known scroller's then you could keep those in
> 4-7 range as appropriate.
> 
> Don't get me wrong... I think this is its own feature and not reason
> to delay patch.
> 
> I'd prefer to document this change though in man pages for ButtonM
> values if we no longer default with ButtonM=M to give user a chance to
> figure out the why's and how's to get scrolling behavior if desired
> (although xinput set-button-map may be preferred way to remap in this
> case).

xinput set-button-map and the ButtonM parameters change two different
values. the former is the server-internal logical button map that all
clients have access to (that's the one affected when you e.g. switch to
left-handed mouse). the ButtonM and the matching map is the driver-internal
map. so anything you set there will appear to the server as the physical
button (see the other email in reply to Ping for pseudocode).

I agree with you on the documentation, I think this should as a whole be
documented in the man page (including the change to n+4).

How about this one below?

Cheers,
  Peter

>From ba85c208cee91237c2bfed4188ad00c0895d9434 Mon Sep 17 00:00:00 2001
From: Peter Hutterer <[email protected]>
Date: Tue, 23 Feb 2010 11:16:51 +1000
Subject: [PATCH] man: update man page for ButtonM option.

Notes the usage of the driver-internal button mapping in more detail and
updates the new default accommodating scroll wheels.

Also included - replace Xinput with X server, the term Xinput is heavily
overloaded and not quite correct here anyway.

Signed-off-by: Peter Hutterer <[email protected]>
---
 man/wacom.man |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/man/wacom.man b/man/wacom.man
index 8bfa9f3..4690758 100644
--- a/man/wacom.man
+++ b/man/wacom.man
@@ -118,9 +118,15 @@ disables the device's motion events.  Default to off.
 .B Option \fI"ButtonM"\fP \fI"AC"\fP
 reports an action AC when button M is pressed,  where M 
 is one of the device supported  button numbers,  it can be 1 
-to 32. The default action reported to Xinput is mouse button M click.    
+to 32. Wacom uses a driver-internal button mapping, where any physical
+button appears to the X server as the button specified by the ButtonM
+mapping. Hence, if two physical buttons have the same ButtonM mapping, the
+server will think they are the same physical button.
+The default action reported to the X server is mouse button M click. Because
+X uses buttons 4, 5, 6, and 7 as the four scrolling directions, physical
+buttons 4 and higher are mapped to 8 and higher by default.
 To ignore the button click, i.e., to not report any button click event 
-to Xinput,  use "0" or "button 0".  
+to the X server,  use "0" or "button 0".
 .TP 4
 .B Option \fI"TPCButton"\fP \fI"on"|"off"\fP
 enables the stylus buttons as  Tablet PC buttons,  i.e., reports stylus 
-- 
1.6.6.1


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to