Acked-by:  Ping Cheng  <[email protected]>

Both the attached patch below and the man page patch of this thread
look good to me. I know my comment below is outside of the two patches
that we are talking about, I'd still like to bring it up one more time
so someone may fix the issue in the server.

With the following line:

> +       nbbuttons = (nbbuttons > 3) ? nbbuttons + 4 : 7;

we will not be able to send a button event larger than 7 for a device
has less than 4 buttons and nbbuttons + 4 for a device has less than
nbbuttons+1 buttons.  This is not "nice".  I think the X server needs
to have a separate entity to store the maximum number of server
supported button events. The number of physical buttons of a device
supports has nothing to do with which button events the physical
button can post.

Ping

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to