I'll give Peter's repo a spin tonight, and report back.
On Mar 4, 2010 5:36 PM, "Chris Bagwell" <ch...@cnpbagwell.com> wrote:
For all in series:
Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com>
For this patch, I also noticed this mis-placed code while reviewing
isdv4GetRanges() recently. It seems the basic issue is that serial
ports can return variable sized packets based on what user is doing.
That tells me setting initial values for wcmPktLength in
isdv4GetRanges() is a waste of time and also to lesser extent the
setting in isdv4InitISDV4(). Possible future cleanup item.
I'm glad in patch 4/5, you got rid of a while() that referenced
wcmPktLength because what it was really wanting to do was check a
non-existing wcmMinimumPktLength value. Also, because wcmPktLength
was initialized outside the while(), it required all packets in single
data buffer to be of same type which seems a wrong assumption to me.
Hopefully, that patch fixes bug tracker #2952501.
So I guess I'm saying I think your patch 4/5 is more important then
your description implies. :-)
Chris
On Thu, Mar 4, 2010 at 6:22 PM, Peter Hutterer <peter.hutte...@who-t.net>
wrote:
> The packet lengt...
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
