Peter, Attached is a test I did in xournal, exported to pdf. This test was only with the pen. I pulled from the devel branch on sf.
On the left side I tried to draw fast, and on the right slow. First of all, this does seem to fix what I was seeing in #2952501. It also provides more evidence that my touch issue in the bug notes is a different issue. Sometimes when I slightly touch the screen, moving my finger around in a circle, the touch cursor jumps to 0,0. Hence clicking the Applications menu in gnome. When I draw fast with the pen the circle is more of a polygon, but when I draw the circle slowly it looks fine. Some kind of tracking issue? I also noticed that sometimes when I flipped to the eraser that it was still drawing with the stylus. Only after using the stylus did the eraser go back to being the eraser. This might also be an issue with xournal. And after doing this test, touch stopped working. Touch returned after restarting the xserver. I checked the Xorg.0.log.old after restarting and still see: (WW) wcmSerialValidate: bad magic at 3 v=a4 l=9 (WW) wcmSerialValidate: bad magic at 3 v=a4 l=9 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 4 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 1 v=a4 l=5 (WW) wcmSerialValidate: bad magic at 5 v=91 l=9 (WW) wcmSerialValidate: bad magic at 2 v=a1 l=5 (WW) wcmSerialValidate: bad magic at 2 v=a1 l=5 (WW) wcmSerialValidate: bad magic at 2 v=a1 l=5 (WW) wcmSerialValidate: bad magic at 1 v=91 l=9 (WW) wcmSerialValidate: bad magic at 1 v=91 l=9 (WW) wcmSerialValidate: bad magic at 1 v=91 l=9 (WW) wcmSerialValidate: bad magic at 8 v=a1 l=9 (WW) wcmSerialValidate: bad magic at 8 v=a1 l=9 (WW) wcmSerialValidate: bad magic at 8 v=a1 l=9 (WW) wcmSerialValidate: bad magic at 1 v=91 l=9 I do not see these warnings when using touch. I hope this feedback helps -Bryan On Thu, Mar 4, 2010 at 6:54 PM, Bryan Hundven <bryanhund...@gmail.com> wrote: > I'll give Peter's repo a spin tonight, and report back. > > On Mar 4, 2010 5:36 PM, "Chris Bagwell" <ch...@cnpbagwell.com> wrote: > > For all in series: > > Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com> > > For this patch, I also noticed this mis-placed code while reviewing > isdv4GetRanges() recently. It seems the basic issue is that serial > ports can return variable sized packets based on what user is doing. > That tells me setting initial values for wcmPktLength in > isdv4GetRanges() is a waste of time and also to lesser extent the > setting in isdv4InitISDV4(). Possible future cleanup item. > > I'm glad in patch 4/5, you got rid of a while() that referenced > wcmPktLength because what it was really wanting to do was check a > non-existing wcmMinimumPktLength value. Also, because wcmPktLength > was initialized outside the while(), it required all packets in single > data buffer to be of same type which seems a wrong assumption to me. > Hopefully, that patch fixes bug tracker #2952501. > > So I guess I'm saying I think your patch 4/5 is more important then > your description implies. :-) > > Chris > > On Thu, Mar 4, 2010 at 6:22 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: >> The packet lengt... -- Bryan Hundven bryanhund...@gmail.com
2010-03-04-test-isdv4-in-xournal-21-58.pdf
Description: Adobe PDF document
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
