On Mon, Sep 06, 2010 at 06:14:07AM +0200, Ping Cheng wrote:
> On Monday, September 6, 2010, Peter Hutterer <[email protected]> wrote:
> > Any client that applies keymaps after the device was detected will overwrite
> > this custom keymap. This is the case with e.g. GNOME, so going through the
> > effort of defining a keymap is short-lived.
> >
> > If a special keymap is required, the XKB options can be set accordingly
> > though they will suffer from the same issue described above.
> >
> > Signed-off-by: Peter Hutterer <[email protected]>
> > ---
> >  src/xf86Wacom.c |  147 
> > +------------------------------------------------------
> >  1 files changed, 1 insertions(+), 146 deletions(-)
> >
> > diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
> > index 2286385..35b3101 100644
> > --- a/src/xf86Wacom.c
> > +++ b/src/xf86Wacom.c
> > @@ -359,135 +359,6 @@ void wcmInitialCoordinates(InputInfoPtr pInfo, int 
> > axis)
> >         return;
> >  }
> >
> > -/* Define our own keymap so we can send key-events with our own device and 
> > not
> > - * rely on inputInfo.keyboard */
> > -static KeySym keymap[] = {
> 
> Do we still use keymap somewhere in the code (I can not access the
> code right now)? If not, this patch gets my acked-by tag.

nope, that was the only use of it. Thanks for the review.

btw: 
http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/xf86-input-wacom;a=summary
has the web-accessible code.

Cheers,
  Peter

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to