On Mon, Sep 06, 2010 at 06:35:44AM +0200, Ping Cheng wrote: > On Monday, September 6, 2010, Peter Hutterer <[email protected]> wrote: > > Input drivers are not in the business of exporting screen coordinates. > > Especially since these are likely to be incorrect in the light of RandR 1.2 > > and later. > > > > Signed-off-by: Peter Hutterer <[email protected]> > > --- > > include/wacom-properties.h | 2 +- > > src/wcmXCommand.c | 15 +--- > > tools/xsetwacom.c | 256 > > -------------------------------------------- > > 3 files changed, 2 insertions(+), 271 deletions(-) > > > > diff --git a/include/wacom-properties.h b/include/wacom-properties.h > > index f6633a1..15e0e35 100644 > > --- a/include/wacom-properties.h > > +++ b/include/wacom-properties.h > > @@ -54,7 +54,7 @@ > > /* 8 bit 3 values, screen number, twinview on/off, multimonitor */ > > #define WACOM_PROP_DISPLAY_OPTS "Wacom Display Options" > > > > -/* 32 bit, 4 values, top x, top y, bottom x, bottom y */ > > +/* DEPRECATED. DO NOT USE */ > > #define WACOM_PROP_SCREENAREA "Wacom Screen Area" > > Why do we still need those two defines above?
because clients may use wacom-properties.h and removing it would break those clients. I'm not sure if there are any though, tbh. > > /* 32 bit, 1 value */ > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c > > index 87669ea..1f3fcb6 100644 > > --- a/src/wcmXCommand.c > > +++ b/src/wcmXCommand.c > > @@ -95,7 +95,6 @@ Atom prop_strip_buttons; > > Atom prop_wheel_buttons; > > Atom prop_display; > > Atom prop_tv_resolutions; > > -Atom prop_screen; > > Atom prop_cursorprox; > > Atom prop_capacity; > > Atom prop_threshold; > > @@ -203,12 +202,6 @@ void InitWcmDeviceProperties(InputInfoPtr pInfo) > > values[2] = priv->wcmMMonitor; > > prop_display = InitWcmAtom(pInfo->dev, WACOM_PROP_DISPLAY_OPTS, 8, > > 3, values); > > Why do we still need this prop? the property contains two more values, screen_number and mmonitor. I haven't removed those two from the driver yet (not 100% sure how yet). Cheers, Peter ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
