On Mon, Sep 06, 2010 at 07:42:31PM -0500, ch...@cnpbagwell.com wrote:
> From: Chris Bagwell <ch...@cnpbagwell.com>
>
> Remove part of code that tried to detect invalid packets coming
> from touchpad because of known issues from filtering of events
> in Bamboo Touch drivers that do not use MT kernel interface.
>
> The size BAMBOO_TOUCH_JUMPED is to small and can hit logic
> during normal finger movements. To end user it will look like
> touchpad freezes until they remove their finger. This freeze
> has been reported by at least a couple of end users to mailing
> list.
>
> This is REALY noticable issue when working with MT version of
> Bamboo driver because its scalled up the reported X/Y values
> and ANY movement will exceed BAMBOO_TOUCH_JUMPED. Unless code
> is removed, Bamboo Touch MT can not work with xf86-input-wacom.
>
> Removed code instead of trying to fix it because it can't be fixed
> without also breaking gesture logic and the new MT driver solves root
> issue.
>
> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com>
merged, thanks.
> ---
> src/wcmCommon.c | 16 ----------------
> 1 files changed, 0 insertions(+), 16 deletions(-)
>
> diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> index 7e50878..a946240 100644
> --- a/src/wcmCommon.c
> +++ b/src/wcmCommon.c
> @@ -30,9 +30,6 @@
> #define THRESHOLD_TOLERANCE (FILTER_PRESSURE_RES / 125)
> #define DEFAULT_THRESHOLD (FILTER_PRESSURE_RES / 75)
>
> -/* Tested result for Bamboo touch jump */
> -#define BAMBOO_TOUCH_JUMPED 30
> -
>
> /*****************************************************************************
> * Static functions
>
> ****************************************************************************/
> @@ -1043,19 +1040,6 @@ void wcmEvent(WacomCommonPtr common, unsigned int
> channel,
> return; /* discard */
> }
>
> - /* ignore Bamboo touch data if point is abnormal */
> - if ((ds.device_type == TOUCH_ID) && (common->tablet_id >= 0xd0
> - && common->tablet_id <= 0xd3) && ds.proximity)
> - {
> - if (!(ds.x * ds.y) || (pLast->proximity &&
> - (abs(ds.x - pLast->x) > BAMBOO_TOUCH_JUMPED ||
> - abs(ds.y - pLast->y) > BAMBOO_TOUCH_JUMPED)))
> - {
> - /* ignore the data */
> - goto ret;
> - }
> - }
> -
> if (TabletHasFeature(common, WCM_ROTATION) &&
> TabletHasFeature(common, WCM_RING)) /* I4 */
> {
> --
> 1.7.2.2
>
>
> ------------------------------------------------------------------------------
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
Cheers,
Peter
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
