From: Chris Bagwell <ch...@cnpbagwell.com> status summary: Need sign offs for patches #3, #5, and #6 before committing.
Changes since v2 include: Fixed commit comment typos in patch #1 as pointed out by Ping. Split v2 patch #5 into two patches (5 and 6 now). The logic to only call wcmEvent when valid events received is useful on its own so pull that out reduce noise while reviewing meat of #6. Ping pointed out that for tablets with mouse pucks, we need to send button presses to mouse device/channel. So I renamed variables and functions to refer to BTN channel instead of PAD channel (we are computing channel to send buttons to and we are not computing channel number of pad device). For Procotol 4 and 5 devices, you can read patch #6 like it simply split usbParseKeyEvent() into two functions with no logic change because we always pass "ds" into both (ds == btn_ds). For generic tablets, the second function will pass in btn_ds which will point to pad device always. Also new to patch #6 is logic to prevent double call to wcmEvent() for protocol 4 and 5 devices (rare case would have been ignored because of wcmCheckSuppress() though). Chris Bagwell (6): Refactor channel selection logic Centralize validating of event queue sizes. document special logic done while going in-prox Increase MAX_CHANNELS to 3 to handle Bamboo's max. Only call wcmEvent() if valid event received. Support tablet buttons without serial #'s. src/wcmUSB.c | 223 +++++++++++++++++++++++++++++++++++++++++---------- src/xf86WacomDefs.h | 2 +- 2 files changed, 180 insertions(+), 45 deletions(-) -- 1.7.3.1 ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
