On Tue, Oct 26, 2010 at 02:11:42PM -0500, Chris Bagwell wrote: > On Tue, Oct 26, 2010 at 1:59 PM, Ping Cheng <pingli...@gmail.com> wrote: > > On Sun, Oct 24, 2010 at 12:40 PM, <ch...@cnpbagwell.com> wrote: > >> From: Chris Bagwell <ch...@cnpbagwell.com> > >> > >> There is an implied agreement between kernel drivers and > >> user land to work around event filtering issues. Document > >> our current approach since it seems not so obvious the > >> importance of a memset(). > >> > >> Our current approach works great with wacom tablets but > >> has some issues with non-wacom tablets. List some TODO's > >> to aid those developers in the future. > >> > >> Also, forcing in proximity handles a few corner cases fine for > >> all wacom devices but document the preferred approach for > >> possible future patch. > >> > >> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com> > > > > Reviewed-by: Ping Cheng <pingli...@gmail.com> > > > > Thank you Chris for adding the comments for non-Wacom devices while we > > are becoming device neutral these days. > > > > I may be unable to reply to your other two patches before next month. > > > > Ping > > Thanks for this review, Ping. > > Peter, patches #1 to #4 now have reviews or acks. Could you please > commit those even if you would like to hold off on #5 and #6? Those > are stand alone code cleanups that the new features in #5 and #6 build > upon.
I've pushed 1-5, for 6 I need to shuffle things out of my brain before I can fully concentrate on the review and that's a bit hard atm. should hopefully get it out of the way by the end of the week though. thanks for the work! Cheers, Peter ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
