On Sun, Nov 14, 2010 at 11:01 PM, Ping Cheng <pingli...@gmail.com> wrote:
> On Sun, Nov 14, 2010 at 9:08 AM, <ch...@cnpbagwell.com> wrote:
> > From: Chris Bagwell <ch...@cnpbagwell.com>
> >
> > This helps abstract out filtering better and also allows
> > custom behavior on storing of samples as well; such as not
> > moving avg window if no X/Y values have changed in current
> > event cycle.
>
> I am a bit confused with the last sentence above. I think we move the
> window even X/Y values stay the same. The code looks like that.
Your right that current code moves window always. The custom behavior was
most important part of sentence. We can now register per-hardware filter
routines easy and these routines can implement behavior of last sentence as
they like.
I will be re-sending some patches that do that last sentence soon (a hidden
patch 7).
> The patch set looks fine to me.
>
Thanks!
Chris
>
> > Intent of this change is refactor only (no behavior change).
> > Most off diff is moving logic over to wcmFilter.c. There is minor
> > flow difference because RawFilter() and wcmCheckSuppress() needs
> > to be kept in wcmCommon.c, and so outside logic that stores samples,
> > but intent is same results.
> >
> > Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com>
>
> Reviewed-by: Ping Cheng <pingli...@gmail.com>
>
> Ping
>
>
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
