On Thu, Dec 02, 2010 at 05:11:41PM -0500, Gaetan Nadon wrote: > Problem introduced in commit 8f1dd625e00c182ec1b6a92b277214d1b8f88986. > > # Store the list of server defined optional extensions in REQUIRED_MODULES > XORG_DRIVER_CHECK_EXT(RANDR, randrproto) > > The role of the driver check macro is to supply the name of optional extension > to the PKG_CHECK_MODULES through the REQUIRED_MODULES variable. > By reversing the order of the statements the variable is empty. > > The real fix would be to have 2 PKG_CHECK_MODULES statements, one to ensure > the server is present at the correct level and one to check the dependencies. > > This won't be necessary as the RANDR extension is not optional, > it is always present. It can simply go next to the others.
why do input drivers need randrproto though? Is this a inclusion dependency result? no problems with your patch, just interested here. xsetwacom needs libXrandr, but not randrproto (though I thing this gets pulled in automatically then). Cheers, Peter > All the xorg drivers have this flaw. > > This undetected missing randr ext problem only happens with server 1.8 or > prior, > as a new Requires.private statement has been added to server 1.9. > > Signed-off-by: Gaetan Nadon <mems...@videotron.ca> > --- > configure.ac | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index ede9a7f..0bb2482 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -48,10 +48,7 @@ XORG_DEFAULT_OPTIONS > AC_CHECK_LIB([m], [rint]) > > # Obtain compiler/linker options from server and required extensions > -PKG_CHECK_MODULES(XORG, [xorg-server >= 1.7.0] xproto xext kbproto > inputproto $REQUIRED_MODULES) > - > -# Store the list of server defined optional extensions in REQUIRED_MODULES > -XORG_DRIVER_CHECK_EXT(RANDR, randrproto) > +PKG_CHECK_MODULES(XORG, [xorg-server >= 1.7.0] xproto xext kbproto > inputproto randrproto) > > # Obtain compiler/linker options for the xsetwacom tool > PKG_CHECK_MODULES(X11, x11 xi xrandr) > -- > 1.6.0.4 ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
