On Mon, Dec 20, 2010 at 7:49 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Dec 20, 2010 at 02:07:14PM -0600, ch...@cnpbagwell.com wrote: >> From: Chris Bagwell <ch...@cnpbagwell.com> >> >> This patch adds support for processing multi-touch (MT) kernel events. >> To do this, it must filter out older style single touch (ST) events >> to prevent conflicts. >> >> For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger. >> >> In older Bamboo kernel driver, serial #1 == 1st finger and serial #2 == >> 2nd finger. Mapping to channel was serial # - 1 and events had to >> come in isolated by separate BTN_TOOL_DOUBLETAP/TRIPLETAP messages. >> >> With newer MT kernel driver, MT slot 0 == 1st finger and MT slot 1 == >> 2nd finger. Take advantage of this straight mapping to channel. >> Code will ignore ST-style events then MT packets will write to >> either channel 0 or 1 or both. >> >> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com> >> --- >> >> Updated based on Peter's comments. > > just for the future: please replace PATCH with PATCH v2, v3, etc. depending > on the version. it makes it a lot easier to go back through email archives > to figure out which patch is the latest. especially since comments on > patches don't always come in-order of the patches sent (more of a problem on > other lists,but it's a good habit to get into) > > merged, thanks >
Sure thing. Normally, I do that. BTW, I was getting ready to hit enter on an update to this patch. It has 1 line change compared to what you commited where I changed a EV_ABS to EV_KEY in filter routine for BTN_TOOL_* items. How do you want me to handle? Send a 1 line patch? Resend patch? I'll go ahead and do later to save time. Just let me know if I should do a separate patch. Chris ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
