On Sun, Jan 16, 2011 at 10:02:15PM -0600, [email protected] wrote:
> From: Chris Bagwell <[email protected]>
>
> wcmRotateAndScaleCoordinates() uses these values to scale
> values based on axis initialization. The change to use -1..-1
> caused it to scale in a way that cursor was overly accelerated.
>
> This is a modified revert to a commit. Before -1..-1
> change, the code would set range to 0..maxX/Y but this
> commit changes to match absolute mode behavior. They both come
> to same answer anyways.
>
> Signed-off-by: Chris Bagwell <[email protected]>
> ---
> src/xf86Wacom.c | 16 ++++------------
> 1 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
> index d74a545..b5b03f8 100644
> --- a/src/xf86Wacom.c
> +++ b/src/xf86Wacom.c
> @@ -273,12 +273,8 @@ wcmInitAxes(DeviceIntPtr pWcm)
>
> /* first valuator: x */
> label = XIGetKnownProperty(AXIS_LABEL_PROP_ABS_X);
> - min = max = -1;
> - if (is_absolute(pInfo))
> - {
> - min = priv->topX;
> - max = priv->sizeX + priv->topX;
> - }
> + min = priv->topX;
> + max = priv->sizeX + priv->topX;
having looked at the twinview code in 0.10.5 (the version we ship in RHEL)
again yesterday and the changes in upstream, I don't think there's a case in
git right now where max != bottomX. in fact, sizeX seems to always be
bottomX - topX. might be worth looking at if you have the time.
merged this one as-is regardless. thanks.
Cheers,
Peter
> min_res = 0;
> max_res = priv->resolX;
> res = priv->resolX;
> @@ -296,12 +292,8 @@ wcmInitAxes(DeviceIntPtr pWcm)
>
> /* second valuator: y */
> label = XIGetKnownProperty(AXIS_LABEL_PROP_ABS_Y);
> - min = max = -1;
> - if (is_absolute(pInfo))
> - {
> - min = priv->topY;
> - max = priv->sizeY + priv->topY;
> - }
> + min = priv->topY;
> + max = priv->sizeY + priv->topY;
> min_res = 0;
> max_res = priv->resolY;
> res = priv->resolY;
> --
> 1.7.3.4
>
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
