On Mon, Oct 15, 2012 at 09:02:28PM -0500, Chris Bagwell wrote: > On Mon, Oct 15, 2012 at 8:34 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > We want libwacom to react to changes in Makefile.am's > > > > Long writeup: > > http://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/ > > > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > For what its worth, for projects that do like to enable maintainer > mode, I prefer they also check in the Makefile.in's because of the > grief that can occur when git is missing them and configure is > ignoring that role. Since wacom doesn't check them in, I also prefer > deleting this line.
Can you expand on the git issue you point out here? I'm not sure what you mean. > Also, I think projects that distribute an autogen.sh scripts have > their roots in this setting as well. Its primary feature is a short > cut to force Makefile regeneration when we've gone out of our way to > disable that automatice feature. Its an option to either delete that > script now or remove the configure part. Hopefully, people that muck > with configure.ac scripts already know you need to run autoreconf > after modifying it and the Makefile will now have working rules to > rerun configure after modifying Makefile.am. regarding autogen.sh, I'll squash in the commit to remove --enable-maintainer-mode from that script since it's now useless anyway, but I'd like to leave the script there for now, if only because of habit. fwiw, I personally really hate it that one project I'm working on _doesn't_ call configure from autogen. it's annoying, forcing me to run two commands where I could only need to run one. > Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com> thanks. Cheers, Peter > > > --- > > configure.ac | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index 432f0e7..e510e2f 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -5,7 +5,6 @@ AC_CONFIG_HEADERS([config.h]) > > > > # Initialize Automake > > AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip check-news]) > > -AM_MAINTAINER_MODE > > > > # Enable silent build when available (Automake 1.11) > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])]) > > -- > > 1.7.11.4 > > ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
