On Mon, Nov 19, 2012 at 10:18:55AM +1000, Peter Hutterer wrote: > On Sat, Nov 17, 2012 at 12:39:08AM +1030, Ron wrote: > > > > Hi, > > > > Sorry to be late to the party on this one, but could we please > > change this to instead use: > > > > AM_MAINTAINER_MODE([enabled]) > > > > This gives the same default behaviour as removing it (which I > > agree is desirable), but still enables people to use the > > --disable-maintainer-mode option to configure, if they really > > want to switch it off again (which I do for the package builds > > since we don't really want a borked timestamp regenerating these > > files unexpectedly in the source package). > > where do you get the busted timestamps from? that seems to be the bug that > should get fixed.
Well, to the extent that it's a 'bug', it would be a bug in git, which exhibits the same quirkyness as CVS did, namely it doesn't preserve timestamps on export :) And I doubt we'll ever get that fixed ... The problem occurs with the packages because I'm committing a minor heresy: for each release I fork an integration branch, which *does* have the autoconf generated files committed to it. The reason for doing that is it gives me a precise record of exactly what was in the release tarball, that I can recreate at any later time if needed, but stored as git deltas rather than having to keep archives of all the exported tarballs themselves. It also lets me easily see and review exactly what changes occurred in the generated files for each release. Which really *has* been less of a problem the last few years now, but hasn't always been so for autoconf and its macros, and the time this saves when needed to debug something they broke is well worth the little bit of disk space I pay to keep a permanent record of what worked previously. It basically gives me the best of both worlds, we don't have generated files cluttering up the mainline branch for every commit there, but I do have a record of what they looked like for each actual release. There are surely schools of thought that will argue this is itself a 'buggy' way of working - but it does work very well for storing _everything_ about a particular release snapshot in just one place that I can trivially clone wherever it's needed. Except for the bit where exporting it from git mangles the timestamps and maintainer-mode would then try to regenerate files instead of using the ones that it has. I know the old ones worked, and if I need them regenerated, I can run autogen, and commit those changes as a _new_ source package - which is basically what it then is. I am the special case here, so it's correct to change the default for what should be the common case. I just need to be able to turn that off explicitly for this particular use when running configure in the package build script. > btw, I suspect that sooner or later the X.Org repos will all be switched > (server already is) so you need to bring up the issue on the xorg-devel list > too. That may not be a problem for the folk maintaining the X packages, they have their own boilerplate and methodology for pulling packages from git and I think they do just regenerate this stuff at every build. Even so, it probably would be nice to use AM_MAINTAINER_MODE([enabled]) everywhere that this is being changed. It takes nothing away from the preferred default, but leaves people with choice if they do need it. Cheers, Ron > > On Tue, Oct 16, 2012 at 11:34:26AM +1000, Peter Hutterer wrote: > > > We want libwacom to react to changes in Makefile.am's > > > > > > Long writeup: > > > http://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/ > > > > > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > > --- > > > configure.ac | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/configure.ac b/configure.ac > > > index 432f0e7..e510e2f 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -5,7 +5,6 @@ AC_CONFIG_HEADERS([config.h]) > > > > > > # Initialize Automake > > > AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip check-news]) > > > -AM_MAINTAINER_MODE > > > > > > # Enable silent build when available (Automake 1.11) > > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])]) > > > -- > > > 1.7.11.4 ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
