Hi Peter, ----- Original Message ----- > From: "Peter Hutterer" <[email protected]> > To: "Joaquim Rocha" <[email protected]> > Cc: [email protected] > Sent: Thursday, May 23, 2013 3:00:57 AM > Subject: Re: [Linuxwacom-devel] Script to clean new SVG layouts > > > +def apply_id_and_class_from_group(group_node): > > + button_assigned = label_assigned = path_assigned = False > > + _id = group_node.attrib.get('id') > > + if _id is None: > > + return > > + for child in group_node.getchildren(): > > + if child == 'rect' or child == 'circle': > > shouldn't these be child.tag?
They should... I didn't notice anything weird in the tests I did though. I will change them anyway in order to at least be consistent with the rest of the file. Thanks for the detection ;) > > with that fixed (or not-fixed if not needed) > Reviewed-by: Peter Hutterer <[email protected]> > > feel free to push when ready I will. Cheers, -- Joaquim Rocha http://www.joaquimrocha.com ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
