After reading wcmCommon.c again, I think the original rotation code isn't right either. I'll fixed it and post a new package, 0.7.6-3, soon.
Thanks for all your support and replies.
Ping
if (ABS(dsOrig->rotation - dsNew->rotation) > suppress ||
(1800 - ABS(dsNew->rotation - dsOrig->rotation)) > suppress)
On 9/14/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
The changes in wcmCommon.c are either syntax change (casting fs to a point) or wrong (ABS(dsOrig->rotation - dsNew->rotation) > suppress and (1800 - ABS(dsNew->rotation - dsOrig->rotation)) > suppress can never be true the same time). So, I don't see a reason to apply them.The only real change that affects suppress is the one in xf86Wacom.h:+#define MAX_SUPPRESS 20 /* max value of suppress */From our experience on other platforms (Windows, Mac...), a suppress value larger than 6 will reduce the data accuracy that causes other issues. This is why we didn't let anyone to use a suppress larger than 6. And, I think, this is why some people feel suppress doesn't work since they tried a value larger than 6.Anyway, I've changed 6 to 20 as the patch suggested. But, I recommend that a suppress larger than 6 will not be used unless you either know what you are doing or you will not complain about losing too much data :).Ping
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Linuxwacom-discuss mailing list Linuxwacom-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss
