Hi Lars, Thanks for the review.
A PR to fix the nits and replacing the broken URL with a permanent one is available at: https://github.com/boucadair/draft-ietf-lisp-pubsub/pull/12 Cheers, Med > -----Message d'origine----- > De : lisp <[email protected]> De la part de Lars Eggert via > Datatracker > Envoyé : lundi 13 février 2023 15:01 > À : The IESG <[email protected]> > Cc : [email protected]; [email protected]; > [email protected] > Objet : [lisp] Lars Eggert's No Objection on draft-ietf-lisp- > pubsub-11: (with COMMENT) > > Lars Eggert has entered the following ballot position for > draft-ietf-lisp-pubsub-11: No Objection > > When responding, please keep the subject line intact and reply to > all email addresses included in the To and CC lines. (Feel free to > cut this introductory paragraph, however.) > > > Please refer to > https://www.ietf.org/about/groups/iesg/statements/handling-ballot- > positions/ > for more information about how to handle DISCUSS and COMMENT > positions. > > > The document, along with other ballot positions, can be found > here: > https://datatracker.ietf.org/doc/draft-ietf-lisp-pubsub/ > > > > ------------------------------------------------------------------ > ---- > COMMENT: > ------------------------------------------------------------------ > ---- > > # GEN AD review of draft-ietf-lisp-pubsub-11 > > CC @larseggert > > Thanks to Roni Even for the General Area Review Team (Gen-ART) > review > (https://mailarchive.ietf.org/arch/msg/gen- > art/cR9bos2756DfJOE43Wen3byzgyk). > > ## Nits > > All comments below are about very minor potential issues that you > may choose to > address in some way - or ignore - as you see fit. Some were > flagged by > automated tools (via https://github.com/larseggert/ietf- > reviewtool), so there > will likely be some false positives. There is no need to let me > know what you > did with these suggestions. > > ### Outdated references > > Document references `draft-boucadair-lisp-pubsub-flow-examples- > 01`, but `-03` > is the latest available revision. > > ### URLs > > These URLs in the document did not return content: > > * https://www.lisp-lab.org > > ### Grammar/style > > #### Section 1, paragraph 8 > ``` > les] for sample flows to illustrate the the use of the PubSub > specification. > ^^^^^^^ > ``` > Possible typo: you repeated a word. > > #### Section 5, paragraph 16 > ``` > Notification Publish Procedures The publish procedure is > implemented via Map > ^^^^^^^^^^^ > ``` > After "The", the verb "publish" doesn't fit. Is "publish" spelled > correctly? If > "publish" is the first word in a compound adjective, use a hyphen > between the > two words. Using the verb "publish" as a noun may be non-standard. > > #### Section 9.1, paragraph 3 > ``` > e time. The following subsections provides an inventory of some > experience le > ^^^^^^^^ > ``` > The verb form "provides" does not seem to match the subject > "subsections". > > ## Notes > > This review is in the ["IETF Comments" Markdown format][ICMF], You > can use the > [`ietf-comments` tool][ICT] to automatically convert this review > into > individual GitHub issues. Review generated by the [`ietf- > reviewtool`][IRT]. > > [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md > [ICT]: https://github.com/mnot/ietf-comments > [IRT]: https://github.com/larseggert/ietf-reviewtool > > > > _______________________________________________ > lisp mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/lisp _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ lisp mailing list [email protected] https://www.ietf.org/mailman/listinfo/lisp
