Thanks for the comments Jason; I will leave libdebugserver.cpp in then.
On 2013-08-08 5:21 PM, "Jason Molenda" <[email protected]> wrote: >I'd prefer to keep libdebugserver.cpp around - I'll look at it. We don't >build it today but there is an old fork of the debugserver sources being >used on a side-project inside Apple that is using libdebugserver.cpp. >Some day that side-project is going to need to update to our current >sources and they'll need libdebugserver.cpp to be there. > >If nothing else, we can #if 0 the entire file for now. > > >On Aug 8, 2013, at 2:16 PM, Malea, Daniel <[email protected]> wrote: > >> Thanks for the comments! >> >> I agree that libdebugserver.cpp looks like dead code. To keep Cmake >>happy, >> it's not sufficient to remove the file from the list of sources; we'd >>need >> to remove it from the directory as well, otherwise the build breaks >> because of "unknown source files". >> >> Does anyone have any issues with removing libdebugserver.cpp? It doesn't >> look like it's been built in a while.. If nobody complains, I will >>remove >> this file when I commit this patch. >> >> >> Thanks, >> Dan >> >> On 2013-08-08 4:51 PM, "Filipe Cabecinhas" >> <[email protected]> wrote: >> >>> >>> I annotated two places to be changed (libdebugserver.cpp in CMakeLists, >>> and the name of the codesign identity. >>> Other than that, LGTM. >>> >>> >>> ================ >>> Comment at: tools/debugserver/source/MacOSX/CMakeLists.txt:47 >>> @@ +46,3 @@ >>> +# Sign the debugserver binary >>> +set (CODESIGN_IDENTITY lldb) >>> +set (CODESIGN_ALLOCATE >>> >>>/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoo >>>lc >>> hain/usr/bin/codesign_allocate) >>> ---------------- >>> This should be the same as in Xcode: lldb_codesign >>> >>> >>> ================ >>> Comment at: tools/debugserver/source/CMakeLists.txt:29 >>> @@ +28,3 @@ >>> + DNBThreadResumeActions.cpp >>> + libdebugserver.cpp >>> + PseudoTerminal.cpp >>> ---------------- >>> libdebugserver.cpp is not in the Xcode project. It seems like dead >>>code. >>> >>> >>> http://llvm-reviews.chandlerc.com/D1331 >> >> >> _______________________________________________ >> lldb-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
