A few things: - all opcode constructors that take uint8/16/32/64 should set the byte order to the host byte order (lldb::endian::InlHostByteOrder()) - The constructor that takes bytes + size should also take a byte order and we should mixup all places that use this constructor to specify a correct byte order
On Oct 4, 2013, at 9:50 AM, Ed Maste <[email protected]> wrote: > The Opcode class does not handle the case where the target and host have > different endianness. > > An opcode set via SetOpcode32 for example is later extracted via GetData() as > a byte sequence in host order rather than target order. > > > http://llvm-reviews.chandlerc.com/D1838 > > Files: > include/lldb/Core/Opcode.h > source/Core/Opcode.cpp > <D1838.1.patch>_______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
