Looks good, though I still vote to have to set the byte order for when setting the opcode to 8/16/32/64 in the constructors. That way the user has to specify exactly the format of the opcode.
On Oct 10, 2013, at 7:46 AM, Ed Maste <[email protected]> wrote: > http://llvm-reviews.chandlerc.com/D1838 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D1838?vs=4677&id=4808#toc > > Files: > include/lldb/Core/Opcode.h > source/Core/Opcode.cpp > source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp > <D1838.2.patch>_______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
