Minor comment tweak. Otherwise this looks good now. Thanks.
I guess Greg wants you to wait for Todd's LGTM? :: shruug :: I know nothing
about LLDB, just cmake. =]
================
Comment at: test/CMakeLists.txt:18-19
@@ -17,14 +17,4 @@
-# Users can override LLDB_TEST_ARGS to modify the way LLDB tests are run. See
help below.
-set(LLDB_TEST_ARGS
- -C
- ${LLDB_TEST_COMPILER}
- CACHE STRING "Specify compiler(s) and architecture(s) with which run LLDB
tests. For example: '-C gcc -C clang -A i386 -A x86_64'"
- )
-string(REPLACE " " ";" LLDB_TEST_ARGS ${LLDB_TEST_ARGS})
-
-set(LLDB_TRACE_DIR "${CMAKE_BINARY_DIR}/lldb-test-traces"
- CACHE STRING "Set directory to output LLDB test traces (for tests that do
not pass.)"
- )
-
-set(LLDB_COMMON_TEST_ARGS
+# The default architecture with which to compile test executables is the
architecture that LLDB
+# itself was built with.
+string(TOLOWER "${LLVM_TARGET_ARCH}" LLDB_DEFAULT_TEST_ARCH)
----------------
This comment isn't quite accurate... Maybe:
"The default architecture with which to compile test executables is the default
LLVM target architecture, which itself defaults to the host architecture."
http://reviews.llvm.org/D4730
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
