Hey Paul, > http://reviews.llvm.org/D4579 - accepted, not commited
I assume this on Todd. > http://reviews.llvm.org/D4580 - waiting on Apple review I replied separately but this looks good to me. > http://reviews.llvm.org/D4430 - waiting for review Greg said on July 10 that this looks fine. His reply didn't end up in the reviews history for some reason. Do you think the error message "index %u is out of range since there are no targets listed" could be improved? Maybe just "There are no active targets". Or " ... out of range since there are no active targets". Whatever, that's a minor nit, the patched version is clearly better. > http://reviews.llvm.org/D5089 - newly added I looked it over quickly & replied. I had a couple of questions about RegisterContextPOSIXProcessMonitor_arm64::ReadRegister but otherwise it looked fine to me. On Aug 28, 2014, at 11:45 PM, Paul Osmialowski <[email protected]> wrote: > Hi Todd, > > I'm sorry for late response, I'm doing things on the run for last three > days, hopefully things will settle down soon. As for my patches I can see > that most of them are already commited. The ones that are waiting I listed > below: > > http://reviews.llvm.org/D4579 - accepted, not commited > http://reviews.llvm.org/D4580 - waiting on Apple review > http://reviews.llvm.org/D4430 - waiting for review > http://reviews.llvm.org/D5089 - newly added > > Cheers, > Paul > > http://reviews.llvm.org/D4381 > > > > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
