On Fri, Aug 29, 2014 at 12:51 AM, Jason Molenda <ja...@molenda.com> wrote:
> Hey Paul, > > > http://reviews.llvm.org/D4579 - accepted, not commited > > I assume this on Todd. > I'll be looking into this one. > > > http://reviews.llvm.org/D4580 - waiting on Apple review > > I replied separately but this looks good to me. > > I'm just going to adjust the header includes and then will check in. > > http://reviews.llvm.org/D4430 - waiting for review > > Greg said on July 10 that this looks fine. His reply didn't end up in the > reviews history for some reason. Do you think the error message "index %u > is out of range since there are no targets listed" could be improved? > Maybe just "There are no active targets". Or " ... out of range since > there are no active targets". Whatever, that's a minor nit, the patched > version is clearly better. > > Greg might need to make a reviews.llvm.org phabricator account. It might not mirror communication from non-members. (If nothing else, there are definitely times where I want to add one or more of you guys as reviewers, generally Greg, but haven't been able to - in which case the mail just comes through the lldb-commits mirroring). I'll wait to hear Paul's feedback before doing anything else with this one. > > http://reviews.llvm.org/D5089 - newly added > > I looked it over quickly & replied. I had a couple of questions about > RegisterContextPOSIXProcessMonitor_arm64::ReadRegister but otherwise it > looked fine to me. > > I'll wait for this one to settle before touching. > > > On Aug 28, 2014, at 11:45 PM, Paul Osmialowski <paw...@king.net.pl> wrote: > > > Hi Todd, > > > > I'm sorry for late response, I'm doing things on the run for last three > > days, hopefully things will settle down soon. As for my patches I can see > > that most of them are already commited. The ones that are waiting I > listed > > below: > > > > http://reviews.llvm.org/D4579 - accepted, not commited > > http://reviews.llvm.org/D4580 - waiting on Apple review > > http://reviews.llvm.org/D4430 - waiting for review > > http://reviews.llvm.org/D5089 - newly added > > > > Cheers, > > Paul > > > > http://reviews.llvm.org/D4381 > > > > > > > > _______________________________________________ > > lldb-commits mailing list > > lldb-commits@cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
_______________________________________________ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits