================ Comment at: test/dosep.py:42 @@ +41,3 @@ + ) + exit_code = subprocess.call(command, shell=True) + if 0 != exit_code: ---------------- This appears to be equivalent to the previous code, but using subprocess instead of os. If this is the only reason in the entire file for importing subprocess, then can we change it back to os.system to avoid importing the extra module? Or alternatively, if the previous call to os.system was the only reason in the entire file for importing os, then keep the subprocess.call but remove the import of os.system.
Other than that, LGTM http://reviews.llvm.org/D6364 _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
