I guess there's a possibility a test on Windows could return 124 and mean something completely different than timeout. Also 124 is a magic number that people won't understand unless they check the man page for timeout and gtimeout.
Can you move the return code checking into the try_timeout function, and then return an enum like eTimedOut, eFailed, eSucceeded? Other than that, looks good. http://reviews.llvm.org/D6364 _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
