I don't understand this:

> NativeProcessLinux initiates ThreadStateCoordinator termination from its own 
> destructor, but in the same time ThreadStateCoordinator references 
> NativeProcessLinux by itself.


Where is the reference from ThreadStateCoordinator to NativeProcessLinux?

I also don't see what difference the Terminate method do on NativeProcessLinux. 
As far as I understand, the compiler generated destructor of 
GDBRemoteCommunicationServerLLGS did exactly the same what you written now 
using the Terminate function. (In both case StopMonitor will be called by the 
destructor of GDBRemoteCommunicationServerLLGS)


================
Comment at: 
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:102-106
@@ -101,2 +101,7 @@
 {
+    if (m_debugged_process_sp)
+    {
+        m_debugged_process_sp->Terminate ();
+        m_debugged_process_sp.reset ();
+    }
 }
----------------
Are you sure you don't have to lock the m_debugged_process_mutex here?

http://reviews.llvm.org/D7692

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to