Hello Vince, I prepared review for this. Take a look please: http://reviews.llvm.org/D8207
Thanks, Ilia On Thu, Mar 5, 2015 at 5:41 AM, Vince Harron <[email protected]> wrote: > Looks good. > > On Wed, Mar 4, 2015 at 9:45 AM, Ilia K <[email protected]> wrote: > >> Vince, >> >> How you think? >> >> Thanks, >> Ilia >> >> On Fri, Feb 27, 2015 at 8:06 AM, Ilia K <[email protected]> wrote: >> >>> Hello Vince, >>> >>> Sorry for delay. We can add lldb-mi folder to PATH in dotest.py (by >>> default) and then we be able to roll back these changes. It will look like: >>> >>>> Index: test/dotest.py >>>> >>> =================================================================== >>> >>> --- test/dotest.py (revision 230655) >>> >>> +++ test/dotest.py (working copy) >>> >>> @@ -932,14 +932,16 @@ >>> >>> >>>> pluginPath = os.path.join(scriptPath, 'plugins') >>> >>> pexpectPath = os.path.join(scriptPath, 'pexpect-2.4') >>> >>> + toolsLldbMiPath = os.path.join(scriptPath, 'tools', 'lldb-mi') >>> >>> >>>> # Put embedded pexpect at front of the load path so we ensure we >>> >>> # use that version. >>> >>> sys.path.insert(0, pexpectPath) >>> >>> >>>> - # Append script dir and plugin dir to the sys.path. >>> >>> + # Append script dir, plugin dir and lldb-mi dir to the sys.path. >>> >>> sys.path.append(scriptPath) >>> >>> sys.path.append(pluginPath) >>> >>> + sys.path.append(toolsLldbMiPath) >>> >>> >>>> # This is our base name component. >>> >>> base = os.path.abspath(os.path.join(scriptPath, os.pardir)) >>> >>> >>> Does it look better? >>> >>> Thanks, >>> Ilia >>> >>> >>> On Wed, Feb 25, 2015 at 3:18 PM, Vince Harron <[email protected]> >>> wrote: >>> >>>> Is it possible to have the application search for the needed binaries >>>> in specific locations instead of requiring the user to add them to the >>>> path? >>>> >>> >>> >> > > > -- > > Vince Harron | Technical Lead Manager | [email protected] | 858-442-0868 >
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
