I agree with Zachary. That wasn't what the FIXME was about, and moving more runtime specific code into target is not what is desired. This should go into the Runtime, and get called by the dynamic loader. I don't think this change is a change in the right direction.
Jim > On Mar 23, 2015, at 11:45 AM, Zachary Turner <[email protected]> wrote: > > Why are we putting logic for a specific language runtime in generic code? > This doesn't seem right to me. > > On Mon, Mar 23, 2015 at 11:38 AM Greg Clayton <[email protected]> wrote: > lgtm > > > http://reviews.llvm.org/D8558 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > > > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
