Siva,
two things:
the reason I prefer to have it return a vector is that we could have a variety
of problems, e.g. missing “const” in the debug info, and I don’t want to have
special-casing everywhere for each one.
I just noticed that in your suggestion ("Is it more meaningful this way”) you
dropped the reference off the std::vector<ConstString> – it should definitely
be passed in by reference.
Sean
> On Apr 6, 2015, at 4:01 PM, Siva Chandra <[email protected]> wrote:
>
> On Mon, Apr 6, 2015 at 3:32 PM, Sean Callanan <[email protected]> wrote:
>
>> I like this; we could have the CXXLanguageRuntime return a list of
>
>> “candidate” remangled names if you can’t find a given one, and then try
>
>> those.
>
>> The function would have the signature
>
>>
>
>> size_t
>
>> CXXLanguageRuntime::GetAlternateManglings(ConstString mangled_name,
>
>> std::vector<ConstString> &alternate_names);
>
>>
>
>> What do you folks think?
>
>
> This sounds good. I will move the meat of this change into CPPLanguageRuntime.
>
> A question: why would there be more than one alternate candidate for a given
> mangled name? There would either be a full mangling (the original) or a
> compressed mangling (the alternate).
>
> [There could be a case where the compressed name is the original and the full
> name is the alternate. But, this case would mean that the clang generated
> name (compressed name) was not found in the target. That is scary because it
> could mean that clang compiled code cannot be linked with code generated by
> other compilers.]
>
>
> http://reviews.llvm.org/D8846
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
