Siva,

two things:

the reason I prefer to have it return a vector is that we could have a variety 
of problems, e.g. missing “const” in the debug info, and I don’t want to have 
special-casing everywhere for each one.
I just noticed that in your suggestion ("Is it more meaningful this way”) you 
dropped the reference off the std::vector<ConstString> – it should definitely 
be passed in by reference.

Sean


http://reviews.llvm.org/D8846

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to