clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks good after indentation fixes.
================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:709-713
@@ +708,7 @@
+
+ const size_t bytes_copied = r2_value.GetAsMemoryData (r2_info,
+ data_sp->GetBytes(),
+ r2_info->byte_size,
+ target_byte_order,
+ error);
+ if (bytes_copied != r2_info->byte_size)
----------------
indent correctly.
================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:722-725
@@ +721,6 @@
+ const size_t bytes_copied = r3_value.GetAsMemoryData (r3_info,
+ data_sp->GetBytes() +
r2_info->byte_size,
+ r3_info->byte_size,
+ target_byte_order,
+ error);
+
----------------
indent correctly.
================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:735-737
@@ +734,5 @@
+ return_valobj_sp = ValueObjectConstResult::Create (&thread,
+
return_clang_type,
+
ConstString(""),
+ return_ext);
+ }
----------------
indent correctly
================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:748-750
@@ -466,1 +747,5 @@
+ return_valobj_sp = ValueObjectMemory::Create (&thread,
+ "",
+ Address (mem_address, NULL),
+ return_clang_type);
}
----------------
indent correctly and use ConstString("")?
Repository:
rL LLVM
http://reviews.llvm.org/D11641
_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
