Re: [Lldb-commits] [PATCH] D11641: Handle floating point and aggregate return types in SysV-mips64 ABI

[Bhushan Attarde]

bhushan added inline comments.

================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:748-750
@@ -466,1 +747,5 @@
+        return_valobj_sp = ValueObjectMemory::Create (&thread,
+                                              "",
+                                              Address (mem_address, NULL),
+                                              return_clang_type); 
     }
----------------
clayborg wrote:
> indent correctly and use ConstString("")?
ValueObjectMemory::Create() requires const char *

           static lldb::ValueObjectSP
           Create (ExecutionContextScope *exe_scope, 
                   const char *name,
                   const Address &address, 
                   const ClangASTType &ast_type);


Repository:
  rL LLVM

http://reviews.llvm.org/D11641




_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits