ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
================
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+ m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false));
}
----------------
The -data-disassemble command has '--' mandatory argument, but now it's always
optional argument. Should it use m_ConsumeArgMandatory as it works for
--thread/--frame etc?
================
Comment at: tools/lldb-mi/MICmdCmdData.cpp:280
@@ -279,3 +278,2 @@
new CMICmdArgValOptionShort(m_constStrArgAddrEnd, true, true,
CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1));
- m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, true));
m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgMode, true, true));
----------------
Please expand MiDataTestCase.test_lldbmi_data_disassemble test to check that it
still gives an error without '--' argument.
http://reviews.llvm.org/D14197
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
